From d2159cc9cc6b7bef8b735a22139b3d8f52e95f85 Mon Sep 17 00:00:00 2001
From: Samuel Vaillant <samuel.vllnt@gmail.com>
Date: Wed, 9 May 2018 20:34:07 +0200
Subject: [PATCH] fix(algoliasearch): add missing createIfNotExists on partial
 update (#25652)

* fix(algoliasearch): add createIfNotExists in callback version of partialUpdateObject(s)

* fix(algoliasearch): add createIfNotExists in promise version of partialUpdateObject(s)

* test(algoliasearch): add tests for partialUpdateObject(s)
---
 types/algoliasearch/algoliasearch-tests.ts | 13 +++++++++++++
 types/algoliasearch/index.d.ts             |  9 +++++----
 2 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/types/algoliasearch/algoliasearch-tests.ts b/types/algoliasearch/algoliasearch-tests.ts
index b8cd1db6c5..2898f889fc 100644
--- a/types/algoliasearch/algoliasearch-tests.ts
+++ b/types/algoliasearch/algoliasearch-tests.ts
@@ -150,4 +150,17 @@ let _algoliaQueryParameters: QueryParameters = {
 let index: Index = algoliasearch('', '').initIndex('');
 
 let search = index.search({ query: '' });
+
 index.search({ query: '' }, (err, res) => {});
+
+// partialUpdateObject
+index.partialUpdateObject({}, () => {});
+index.partialUpdateObject({}, false, () => {});
+index.partialUpdateObject({}).then(() => {});
+index.partialUpdateObject({}, false).then(() => {});
+
+// partialUpdateObjects
+index.partialUpdateObjects([{}], () => {});
+index.partialUpdateObjects([{}], false, () => {});
+index.partialUpdateObjects([{}]).then(() => {});
+index.partialUpdateObjects([{}], false).then(() => {});
diff --git a/types/algoliasearch/index.d.ts b/types/algoliasearch/index.d.ts
index fca13ac161..87c1f79a0e 100644
--- a/types/algoliasearch/index.d.ts
+++ b/types/algoliasearch/index.d.ts
@@ -286,14 +286,13 @@ declare namespace algoliasearch {
      * https://github.com/algolia/algoliasearch-client-js#update-objects---saveobjects
      */
     partialUpdateObject(object: {}, cb: (err: Error, res: Task) => void): void;
+    partialUpdateObject(object: {}, createIfNotExists: boolean, cb: (err: Error, res: Task) => void): void;
     /**
      * Update parameters of a list of objects
      * https://github.com/algolia/algoliasearch-client-js#update-objects---saveobjects
      */
-    partialUpdateObjects(
-      objects: {}[],
-      cb: (err: Error, res: Task) => void
-    ): void;
+    partialUpdateObjects(objects: {}[], cb: (err: Error, res: Task) => void): void;
+    partialUpdateObjects(objects: {}[], createIfNotExists: boolean, cb: (err: Error, res: Task) => void): void;
     /**
      * Delete a specific object
      * https://github.com/algolia/algoliasearch-client-js#delete-objects---deleteobjects
@@ -531,11 +530,13 @@ declare namespace algoliasearch {
      * https://github.com/algolia/algoliasearch-client-js#update-objects---saveobjects
      */
     partialUpdateObject(object: {}): Promise<Task>;
+    partialUpdateObject(object: {}, createIfNotExists: boolean): Promise<Task>;
     /**
      * Update parameters of a list of objects
      * https://github.com/algolia/algoliasearch-client-js#update-objects---saveobjects
      */
     partialUpdateObjects(objects: {}[]): Promise<Task>;
+    partialUpdateObjects(objects: {}[], createIfNotExists?: boolean): Promise<Task>;
     /**
      * Delete a specific object
      * https://github.com/algolia/algoliasearch-client-js#delete-objects---deleteobjects