From d380ec447529f368451b9705ce80872979678737 Mon Sep 17 00:00:00 2001 From: Pete Gonzalez <4673363+octogonz@users.noreply.github.com> Date: Mon, 18 Mar 2019 18:35:55 -0700 Subject: [PATCH] Fix incorrect typings for clone-deep (#33990) * Fix incorrect typings for clone-deep * Update tsconfig.json to remove the insidious setting that caused the mistake to be overlooked ;-) --- types/clone-deep/clone-deep-tests.ts | 2 +- types/clone-deep/index.d.ts | 4 +++- types/clone-deep/tsconfig.json | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/types/clone-deep/clone-deep-tests.ts b/types/clone-deep/clone-deep-tests.ts index 0e99c6fbb2..6911c13de4 100644 --- a/types/clone-deep/clone-deep-tests.ts +++ b/types/clone-deep/clone-deep-tests.ts @@ -1,4 +1,4 @@ -import cloneDeep from 'clone-deep'; +import cloneDeep = require('clone-deep'); cloneDeep(Object.create(null)); // $ExpectType object cloneDeep({}); // $ExpectType object diff --git a/types/clone-deep/index.d.ts b/types/clone-deep/index.d.ts index 0ca60e6180..7918daaa40 100644 --- a/types/clone-deep/index.d.ts +++ b/types/clone-deep/index.d.ts @@ -4,7 +4,9 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.7 -export default function cloneDeep( +declare function cloneDeep( val: T, instanceClone?: true | ((val: T) => T) ): T; + +export = cloneDeep; diff --git a/types/clone-deep/tsconfig.json b/types/clone-deep/tsconfig.json index d584681520..cb1cebdf1f 100644 --- a/types/clone-deep/tsconfig.json +++ b/types/clone-deep/tsconfig.json @@ -10,7 +10,6 @@ "typeRoots": ["../"], "types": [], "noEmit": true, - "esModuleInterop": true, "forceConsistentCasingInFileNames": true }, "files": ["index.d.ts", "clone-deep-tests.ts"]