From d45ec9519f576a2ed2d5fba3b853f207efacf754 Mon Sep 17 00:00:00 2001
From: Jojoshua <Jojoshua@gmail.com>
Date: Tue, 1 Oct 2019 12:48:37 -0400
Subject: [PATCH] tabulator-tables 4.4.3 (#38702)

* 4.4.3

* test update

* fix version(patch version not allowed)
---
 types/tabulator-tables/index.d.ts                | 2 +-
 types/tabulator-tables/tabulator-tables-tests.ts | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/types/tabulator-tables/index.d.ts b/types/tabulator-tables/index.d.ts
index 1eb5ccad0c..fdff24ff92 100644
--- a/types/tabulator-tables/index.d.ts
+++ b/types/tabulator-tables/index.d.ts
@@ -1175,7 +1175,7 @@ You can pass an optional additional property with sorter, sorterParams that shou
         | ((
               cell: CellComponent,
               onRendered: EmptyCallback,
-              success: ValueVoidCallback,
+              success: ValueBooleanCallback,
               cancel: ValueVoidCallback,
               editorParams: {},
           ) => HTMLElement | false);
diff --git a/types/tabulator-tables/tabulator-tables-tests.ts b/types/tabulator-tables/tabulator-tables-tests.ts
index 64b41d2d32..1cae225a6e 100644
--- a/types/tabulator-tables/tabulator-tables-tests.ts
+++ b/types/tabulator-tables/tabulator-tables-tests.ts
@@ -519,3 +519,9 @@ options.headerSortTristate = true;
 colDef.formatter = 'rowSelection';
 
 options.invalidOptionWarnings = false;
+
+colDef.editor = (cell, onRendered, success, cancel, editorParams) => {
+    const editor = document.createElement('input');
+    const successful: boolean = success('test');
+    return editor;
+};