From d9a55fde8509f7d8cb32acc517f7ac1b4b9eab91 Mon Sep 17 00:00:00 2001
From: NeoDobby <matthias.juchmes@compart.com>
Date: Fri, 8 Jun 2018 09:21:48 +0200
Subject: [PATCH 1/2] [ace] Add missing parameter to setScrollLeft

---
 types/ace/index.d.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/types/ace/index.d.ts b/types/ace/index.d.ts
index 828aab87c2..7faa5da4f8 100644
--- a/types/ace/index.d.ts
+++ b/types/ace/index.d.ts
@@ -832,8 +832,9 @@ declare namespace AceAjax {
 
         /**
          * [Sets the value of the distance between the left of the editor and the leftmost part of the visible content.]{: #EditSession.setScrollLeft}
+         * @param scrollLeft The new scroll left value
         **/
-        setScrollLeft(): void;
+        setScrollLeft(scrollLeft: number): void;
 
         /**
          * [Returns the value of the distance between the left of the editor and the leftmost part of the visible content.]{: #EditSession.getScrollLeft}

From 543cb570ecb5d01e4a0f397d18ed970ac7e7432a Mon Sep 17 00:00:00 2001
From: Matthias Juchmes <matthias,juchmes@compart.com>
Date: Fri, 8 Jun 2018 10:34:52 +0200
Subject: [PATCH 2/2] Add tests

---
 types/ace/test/edit_session.ts | 39 +++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/types/ace/test/edit_session.ts b/types/ace/test/edit_session.ts
index 4713495f7a..29b3bb6bd8 100644
--- a/types/ace/test/edit_session.ts
+++ b/types/ace/test/edit_session.ts
@@ -18,6 +18,23 @@ function createFoldTestSession() {
     return session;
 }
 
+function createScrollTestRenderer(): AceAjax.VirtualRenderer | null {
+    var el = document.createElement("div");
+
+    if (!el.getBoundingClientRect) {
+        console.log("Skipping test: This test only runs in the browser");
+        return null;
+    }
+
+    el.style.left = "20px";
+    el.style.top = "30px";
+    el.style.width = "300px";
+    el.style.height = "100px";
+    document.body.appendChild(el);
+
+    return new AceAjax.VirtualRenderer(el);
+}
+
 function assertArray(a, b) {
     assert.equal(a + "", b + "");
     assert.ok(a.length == b.length);
@@ -915,5 +932,25 @@ const aceEditSessionTests = {
         session = new AceAjax.EditSession(new Array(30).join("\n"));
         session.documentToScreenPosition(2, 0);
         session.documentToScreenPosition(2, 0);
+    },
+
+    "test setScrollTop()": function() {
+        var renderer = createScrollTestRenderer();
+        var session = new AceAjax.EditSession(["1", "2", "3", "2", "3", "4"]);
+        renderer.setSession(session);
+        assert.equal(renderer.getScrollTop(), 0);
+        session.setScrollTop(40);
+        assert.equal(renderer.getScrollTop(), 40);
+        renderer.getScrollTop()
+    },
+
+    "test setScrollLeft()": function() {
+        var renderer = createScrollTestRenderer();
+        var session = new AceAjax.EditSession(["1", "2", "3", "2", "3", "4"]);
+        renderer.setSession(session);
+        assert.equal(renderer.getScrollLeft(), 0);
+        session.setScrollLeft(40);
+        assert.equal(renderer.getScrollLeft(), 40);
+        renderer.getScrollLeft()
     }
-};
\ No newline at end of file
+};