From 04ab9932b1b723280fe8bb407a8828d59b8ffb37 Mon Sep 17 00:00:00 2001 From: nicholasmaddren Date: Wed, 30 Jan 2019 13:02:50 +0000 Subject: [PATCH 1/2] Adds tabIndex to rc-slider --- types/rc-slider/index.d.ts | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/types/rc-slider/index.d.ts b/types/rc-slider/index.d.ts index 420d836034..7efb2842b8 100644 --- a/types/rc-slider/index.d.ts +++ b/types/rc-slider/index.d.ts @@ -5,17 +5,18 @@ // Austin Turner // Jacob Froman // Deanna Veale +// Nick Maddren // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 import * as React from "react"; -import { RCTooltip } from 'rc-tooltip'; +import { RCTooltip } from "rc-tooltip"; export interface Marks { [number: number]: - | JSX.Element - | string - | { style: any; label: string | JSX.Element }; + | JSX.Element + | string + | { style: any; label: string | JSX.Element }; } export interface CommonApiProps { @@ -135,6 +136,11 @@ export interface SliderProps extends CommonApiProps { * Set current value of slider. */ value?: number; + /** + * Set the tabIndex of the slider handle. + * @default 0 + */ + tabIndex: number; } export interface RangeProps extends CommonApiProps { @@ -162,6 +168,11 @@ export interface RangeProps extends CommonApiProps { * Set current positions of handles. */ value?: number[]; + /** + * Set the tabIndex of each handle. + * @default [0,0] + */ + tabIndex: number[]; /** * Determine how many ranges to render, and multiple handles will be rendered (number + 1). * @default 1 @@ -200,9 +211,13 @@ export interface WithTooltipProps { tipProps?: Partial; } -export default class Slider extends React.Component { } -export class Range extends React.Component { } -export class Handle extends React.Component { } +export default class Slider extends React.Component {} +export class Range extends React.Component {} +export class Handle extends React.Component {} -export function createSliderWithTooltip(slider: typeof Slider): new() => React.Component; -export function createSliderWithTooltip(range: typeof Range): new() => React.Component; +export function createSliderWithTooltip( + slider: typeof Slider +): new () => React.Component; +export function createSliderWithTooltip( + range: typeof Range +): new () => React.Component; From 63b66fd5ab69423d20775297e3a3abe109a3f3d6 Mon Sep 17 00:00:00 2001 From: nicholasmaddren Date: Wed, 30 Jan 2019 13:55:46 +0000 Subject: [PATCH 2/2] rc-slider tabIndex optional --- types/rc-slider/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/rc-slider/index.d.ts b/types/rc-slider/index.d.ts index 7efb2842b8..07edca0069 100644 --- a/types/rc-slider/index.d.ts +++ b/types/rc-slider/index.d.ts @@ -140,7 +140,7 @@ export interface SliderProps extends CommonApiProps { * Set the tabIndex of the slider handle. * @default 0 */ - tabIndex: number; + tabIndex?: number; } export interface RangeProps extends CommonApiProps { @@ -172,7 +172,7 @@ export interface RangeProps extends CommonApiProps { * Set the tabIndex of each handle. * @default [0,0] */ - tabIndex: number[]; + tabIndex?: number[]; /** * Determine how many ranges to render, and multiple handles will be rendered (number + 1). * @default 1