From d6ddf4b8aba062f9f9e0401d79bb8487667e4f2b Mon Sep 17 00:00:00 2001 From: TheRealImaginary Date: Wed, 20 Nov 2019 00:07:11 +0200 Subject: [PATCH] feature: Add additional overload for `putObject` (#40414) --- types/minio/index.d.ts | 1 + types/minio/minio-tests.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/types/minio/index.d.ts b/types/minio/index.d.ts index 3cbc5f798e..f7a60b9458 100644 --- a/types/minio/index.d.ts +++ b/types/minio/index.d.ts @@ -124,6 +124,7 @@ export class Client { putObject(bucketName: string, objectName: string, stream: Stream|Buffer|string, size: number, callback: ResultCallback): void; putObject(bucketName: string, objectName: string, stream: Stream|Buffer|string, size: number, metaData: ItemBucketMetadata, callback: ResultCallback): void; putObject(bucketName: string, objectName: string, stream: Stream|Buffer|string, size?: number, metaData?: ItemBucketMetadata): Promise; + putObject(bucketName: string, objectName: string, stream: Stream|Buffer|string, metaData?: ItemBucketMetadata): Promise; fPutObject(bucketName: string, objectName: string, filePath: string, metaData: ItemBucketMetadata, callback: ResultCallback): void; fPutObject(bucketName: string, objectName: string, filePath: string, metaData: ItemBucketMetadata): Promise; diff --git a/types/minio/minio-tests.ts b/types/minio/minio-tests.ts index 41ee93bbf4..efd62ccccf 100644 --- a/types/minio/minio-tests.ts +++ b/types/minio/minio-tests.ts @@ -56,6 +56,7 @@ minio.putObject('testBucket', 'hello.txt', 'hello.txt content', 100, metaData, ( minio.putObject('testBucket', 'hello.jpg', new Stream()); minio.putObject('testBucket', 'hello.jpg', new Buffer('string'), 100); minio.putObject('testBucket', 'hello.txt', 'hello.txt content', 100, metaData); +minio.putObject('testBucket', 'hello.txt', 'hello.txt content', metaData); minio.fPutObject('testBucket', 'hello.jpg', 'file/path', metaData, (error: Error|null, etag: string) => { console.log(error, etag); }); minio.fPutObject('testBucket', 'hello.jpg', 'file/path', metaData);