From 2f931b8761d74733226669dbc24b8636878a5198 Mon Sep 17 00:00:00 2001 From: Jeremy Marzka Date: Mon, 22 May 2017 11:52:42 -0500 Subject: [PATCH] knex: first() should accept the same parameters as select() --- types/knex/index.d.ts | 2 +- types/knex/knex-tests.ts | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/types/knex/index.d.ts b/types/knex/index.d.ts index 16330b4e3a..f8fdb910f1 100644 --- a/types/knex/index.d.ts +++ b/types/knex/index.d.ts @@ -136,7 +136,7 @@ declare namespace Knex { decrement(columnName: string, amount?: number): QueryBuilder; // Others - first(...columns: string[]): QueryBuilder; + first: Select; debug(enabled?: boolean): QueryBuilder; pluck(column: string): QueryBuilder; diff --git a/types/knex/knex-tests.ts b/types/knex/knex-tests.ts index 920b347a70..9e372f29d0 100644 --- a/types/knex/knex-tests.ts +++ b/types/knex/knex-tests.ts @@ -401,6 +401,10 @@ knex.table('users').first('id', 'name').then(function(row) { console.log(row); }); +knex.table('users').first(knex.raw('round(sum(products)) as p')).then(function(row) { + console.log(row); +}); + // Using trx as a query builder: knex.transaction(function(trx) {