From 9dc26b65bde64bdfe1d5203af33368335ddeee7b Mon Sep 17 00:00:00 2001 From: ziga Date: Thu, 6 Jul 2017 17:00:03 -0700 Subject: [PATCH 1/3] Labels support string[] and string[][] As seen here http://www.chartjs.org/samples/latest/scales/multiline-labels.html. [source, see line 29](view-source:http://www.chartjs.org/samples/latest/scales/multiline-labels.html). --- types/chart.js/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/chart.js/index.d.ts b/types/chart.js/index.d.ts index d567492602..bfbe9fb31e 100644 --- a/types/chart.js/index.d.ts +++ b/types/chart.js/index.d.ts @@ -130,7 +130,7 @@ declare namespace Chart { } interface ChartData { - labels?: string[]; + labels?: string[] | string[][]; datasets?: ChartDataSets[]; } From c8246cde9dd78ba4f9b14d5cc26cf17de05efb95 Mon Sep 17 00:00:00 2001 From: ziga Date: Fri, 7 Jul 2017 09:12:12 -0700 Subject: [PATCH 2/3] CR feedback. --- types/chart.js/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/chart.js/index.d.ts b/types/chart.js/index.d.ts index bfbe9fb31e..4d1546fdb3 100644 --- a/types/chart.js/index.d.ts +++ b/types/chart.js/index.d.ts @@ -130,7 +130,7 @@ declare namespace Chart { } interface ChartData { - labels?: string[] | string[][]; + labels?: (string | string[])[]; datasets?: ChartDataSets[]; } From 20134c8278f5546cf2b9ff8d005892904b5a208c Mon Sep 17 00:00:00 2001 From: ziga Date: Fri, 7 Jul 2017 13:52:02 -0700 Subject: [PATCH 3/3] Lint fix. --- types/chart.js/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/chart.js/index.d.ts b/types/chart.js/index.d.ts index 4d1546fdb3..6724d27112 100644 --- a/types/chart.js/index.d.ts +++ b/types/chart.js/index.d.ts @@ -130,7 +130,7 @@ declare namespace Chart { } interface ChartData { - labels?: (string | string[])[]; + labels?: Array; datasets?: ChartDataSets[]; }