From d9e73fad7d1dedbd31ef214fb737ee3a7cab58ab Mon Sep 17 00:00:00 2001 From: Linda_pp Date: Mon, 9 May 2016 17:37:39 +0900 Subject: [PATCH] github-electron: Fix callback's return type of app.makeSingleInstance() (#9250) The callback should return `void`, not `boolean`. https://github.com/electron/electron/blob/master/docs/api/app.md#appmakesingleinstancecallback --- github-electron/github-electron-main-tests.ts | 1 - github-electron/github-electron.d.ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/github-electron/github-electron-main-tests.ts b/github-electron/github-electron-main-tests.ts index a2c40c1d68..00798c382b 100644 --- a/github-electron/github-electron-main-tests.ts +++ b/github-electron/github-electron-main-tests.ts @@ -45,7 +45,6 @@ var shouldQuit = app.makeSingleInstance(function(commandLine, workingDirectory) if (mainWindow.isMinimized()) mainWindow.restore(); mainWindow.focus(); } - return true; }); if (shouldQuit) { diff --git a/github-electron/github-electron.d.ts b/github-electron/github-electron.d.ts index dfcff3d83c..11223154fb 100644 --- a/github-electron/github-electron.d.ts +++ b/github-electron/github-electron.d.ts @@ -280,7 +280,7 @@ declare namespace Electron { * multiple instances of your app to run, this will ensure that only a single instance * of your app is running, and other instances signal this instance and exit. */ - makeSingleInstance(callback: (args: string[], workingDirectory: string) => boolean): boolean; + makeSingleInstance(callback: (args: string[], workingDirectory: string) => void): boolean; /** * Changes the Application User Model ID to id. */