From fa3a9621c6a8adcfbdee694c0be3f0c21e2f2e8c Mon Sep 17 00:00:00 2001 From: mattbrooks2010 Date: Tue, 14 Jan 2014 14:34:53 +0000 Subject: [PATCH] Added missing library features Implemented the following changes. - The HighchartsChartObject.series property should return HighchartsSeriesObject[] not HighchartsSeriesChart[]. - Added missing setVisible(...) overloaded method to the HighchartsSeriesObject interface. - Added missing JQuery.highcharts(...) method overload containing callback function parameter used to manipulate the chart instance. - Amended test file to exercise all changes in this commit. --- highcharts/highcharts-tests.ts | 4 +++- highcharts/highcharts.d.ts | 12 +++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/highcharts/highcharts-tests.ts b/highcharts/highcharts-tests.ts index fe32a89312..f1a4befd01 100644 --- a/highcharts/highcharts-tests.ts +++ b/highcharts/highcharts-tests.ts @@ -110,7 +110,9 @@ var highChartSettings: HighchartsOptions = { }] }; -var container = $("#container").highcharts(highChartSettings); +var container = $("#container").highcharts(highChartSettings, function (chart) { + chart.series[0].setVisible(true, true); +}); var options = Highcharts.getOptions(); diff --git a/highcharts/highcharts.d.ts b/highcharts/highcharts.d.ts index f6f6e92658..64d9f92fc4 100644 --- a/highcharts/highcharts.d.ts +++ b/highcharts/highcharts.d.ts @@ -1004,7 +1004,7 @@ interface HighchartsChartObject { options: HighchartsChartOptions; print(): void; redraw(): void; - series: HighchartsSeriesChart[]; + series: HighchartsSeriesObject[]; setSize(width: number, height: number): void; setSize(width: number, height: number, anumation: boolean): void; setSize(width: number, height: number, anumation: HighchartsAnimation): void; @@ -1109,6 +1109,8 @@ interface HighchartsSeriesObject { setData(data: number[][], redraw: boolean): void; setData(data: HighchartsDataPoint[]): void; // HighchartsDataPoint[] setData(data: HighchartsDataPoint[], redraw: boolean): void; + setVisible(visible: boolean): void; + setVisible(visible: boolean, redraw: boolean): void; show(): void; type: string; visible: boolean; @@ -1124,4 +1126,12 @@ interface JQuery { * @return current {JQuery} selector the current JQuery selector **/ highcharts(options: HighchartsOptions): JQuery; + /** + * Creates a new Highcharts.Chart for the current JQuery selector; usually + * a div selected by $('#container') + * @param {HighchartsOptions} options Options for this chart + * @param callback Callback function used to manipulate the constructed chart instance + * @return current {JQuery} selector the current JQuery selector + **/ + highcharts(options: HighchartsOptions, callback: (chart: HighchartsChartObject) => void): JQuery; }