From 5c5ded7b08c85f752ad158b2a6facb88740cadf0 Mon Sep 17 00:00:00 2001 From: Yves Schelpe Date: Sat, 28 Jan 2017 20:11:44 +0100 Subject: [PATCH 1/3] Function 'pick' returns is documented to always return a value. - See issue https://github.com/DefinitelyTyped/DefinitelyTyped/issues/14319 Function 'pick' returns is documented to always return a value. Before it's return type was :void, I'm sending this proposal as :any would fix this issue. Reference to dot-object documentation: https://github.com/rhalff/dot-object#pickremove-a-value-using-dot-notation --- dot-object/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dot-object/index.d.ts b/dot-object/index.d.ts index 176e1c0daf..cda1ec384c 100644 --- a/dot-object/index.d.ts +++ b/dot-object/index.d.ts @@ -109,7 +109,7 @@ declare namespace DotObject { * @param {Object} obj * @param {Boolean} remove */ - pick(path: string, obj: any, remove?: boolean): void; + pick(path: string, obj: any, remove?: boolean): any; /** * * Remove value from an object using dot notation. From 4262c391b92b544c8fba7475b24e084dc86c4bd9 Mon Sep 17 00:00:00 2001 From: Yves Schelpe Date: Sat, 28 Jan 2017 20:20:54 +0100 Subject: [PATCH 2/3] Bumped version number Bumped version number as asked in checklist --- dot-object/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dot-object/index.d.ts b/dot-object/index.d.ts index cda1ec384c..64a37f3015 100644 --- a/dot-object/index.d.ts +++ b/dot-object/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Dot-Object v1.4.2 +// Type definitions for Dot-Object v1.4.3 // Project: https://github.com/rhalff/dot-object // Definitions by: Niko Kovačič // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped From 8afb9e8a761c462ec0b3e8f9a508a5118a884748 Mon Sep 17 00:00:00 2001 From: Yves Schelpe Date: Sun, 29 Jan 2017 09:27:32 +0100 Subject: [PATCH 3/3] Changed versioning to MAJOR.MINOR To comply with maj.min versioning ref comment https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14320#discussion_r98345142 --- dot-object/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dot-object/index.d.ts b/dot-object/index.d.ts index 64a37f3015..8bb7d0657c 100644 --- a/dot-object/index.d.ts +++ b/dot-object/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for Dot-Object v1.4.3 +// Type definitions for Dot-Object v1.5 // Project: https://github.com/rhalff/dot-object // Definitions by: Niko Kovačič // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped