From dbdb44f48a7da2d639569fd59c8854d840db33af Mon Sep 17 00:00:00 2001 From: Daniil Samoylov Date: Mon, 19 Nov 2018 06:29:04 +1300 Subject: [PATCH] Fix slate minor issues: spelling in function name, Mark instead of MarkJSON in LeafJSON (#30540) * Fix function name getMarksBetweenOffset -> getMarksBetweenOffsets Link to the source https://github.com/ianstormtaylor/slate/blob/a09c3c2fdfe87605988a13e968643f81b4936978/packages/slate/src/models/text.js#L348-L376 * LeafJSON should use MarkJSON instead of Mark --- types/slate/index.d.ts | 4 ++-- types/slate/slate-tests.ts | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/types/slate/index.d.ts b/types/slate/index.d.ts index ac58361ff8..bb35c6483f 100644 --- a/types/slate/index.d.ts +++ b/types/slate/index.d.ts @@ -327,7 +327,7 @@ export class Text extends Immutable.Record({}) { getFirstText(): Text; getLastText(): Text; getText(): string; - getMarksBetweenOffset( + getMarksBetweenOffsets( startOffset: number, endOffset: number ): Immutable.Set; @@ -362,7 +362,7 @@ export interface LeafProperties { } export interface LeafJSON { - marks?: Mark[]; + marks?: MarkJSON[]; text?: string; } diff --git a/types/slate/slate-tests.ts b/types/slate/slate-tests.ts index eb07649cba..344d4da3ee 100644 --- a/types/slate/slate-tests.ts +++ b/types/slate/slate-tests.ts @@ -13,7 +13,10 @@ const node: BlockJSON = { leaves: [ { text: "example", - marks: [] + marks: [{ + data: { testData: "data"}, + type: "mark" + }] } ] }