From e4d53c60ada4ca2ba38c8271b81caa9379761cff Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 11:55:28 +0200 Subject: [PATCH 1/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts.d.ts | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/highcharts/highcharts.d.ts b/highcharts/highcharts.d.ts index 4ea165814f..451e3d248b 100644 --- a/highcharts/highcharts.d.ts +++ b/highcharts/highcharts.d.ts @@ -5754,6 +5754,17 @@ interface HighchartsChartObject { * @since 1.2.0 */ hideLoading(): void; + /** + * Returns true if there are data points within the plot area now + * @return {boolean} If chart has any data. + * @since 3.0.8 + */ + hasData(): boolean; + /** + * Hide the 'No data to display' message added by the no-data-to-display plugin. + * @since 3.0.8 + */ + hideNoData(): void; /** * The options structure for the chart. * @since 1.2.0 @@ -5802,6 +5813,12 @@ interface HighchartsChartObject { * @since 2.1.0 */ setTitle(title: HighchartsTitleOptions, subtitle?: HighchartsSubtitleOptions, redraw?: boolean): void; + /** + * Display a no-data message. + * @param {String} message An optional message to show in place of the default one + * @since 3.0.8 + */ + showNoData(message?: string): void; /** * Dim the chart's plot area and show a loading label text. Options for the loading screen are defined at * options.loading. A custom text can be given as a parameter for loading. From e8eed9cade9a0ce76fd99b66054af072f69d27a0 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 15:52:38 +0200 Subject: [PATCH 2/9] #10342 Added hideNoData/showNoData to highcharts --- ...highcharts-modules-no-data-to-display.d.ts | 22 +++++++++++++++++++ highcharts/highcharts.d.ts | 17 -------------- 2 files changed, 22 insertions(+), 17 deletions(-) create mode 100644 highcharts/highcharts-modules-no-data-to-display.d.ts diff --git a/highcharts/highcharts-modules-no-data-to-display.d.ts b/highcharts/highcharts-modules-no-data-to-display.d.ts new file mode 100644 index 0000000000..6b8ed03e15 --- /dev/null +++ b/highcharts/highcharts-modules-no-data-to-display.d.ts @@ -0,0 +1,22 @@ +/// +interface HighchartsChartObject { + /** + * Returns true if there are data points within the plot area now + * @return {boolean} If chart has any data. + * @since 3.0.8 + */ + hasData(): boolean; + + /** + * Hide the 'No data to display' message added by the no-data-to-display plugin. + * @since 3.0.8 + */ + hideNoData(): void; + + /** + * Display a no-data message. + * @param {String} message An optional message to show in place of the default one + * @since 3.0.8 + */ + showNoData(message?: string): void; +} diff --git a/highcharts/highcharts.d.ts b/highcharts/highcharts.d.ts index 451e3d248b..4ea165814f 100644 --- a/highcharts/highcharts.d.ts +++ b/highcharts/highcharts.d.ts @@ -5754,17 +5754,6 @@ interface HighchartsChartObject { * @since 1.2.0 */ hideLoading(): void; - /** - * Returns true if there are data points within the plot area now - * @return {boolean} If chart has any data. - * @since 3.0.8 - */ - hasData(): boolean; - /** - * Hide the 'No data to display' message added by the no-data-to-display plugin. - * @since 3.0.8 - */ - hideNoData(): void; /** * The options structure for the chart. * @since 1.2.0 @@ -5813,12 +5802,6 @@ interface HighchartsChartObject { * @since 2.1.0 */ setTitle(title: HighchartsTitleOptions, subtitle?: HighchartsSubtitleOptions, redraw?: boolean): void; - /** - * Display a no-data message. - * @param {String} message An optional message to show in place of the default one - * @since 3.0.8 - */ - showNoData(message?: string): void; /** * Dim the chart's plot area and show a loading label text. Options for the loading screen are defined at * options.loading. A custom text can be given as a parameter for loading. From bba9c487953d957dc3d4a5c3b9d32bd67c5716c6 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:05:23 +0200 Subject: [PATCH 3/9] #10342 Added hideNoData/showNoData to highcharts --- .../highcharts-modules-no-data-to-display-tests.ts | 9 +++++++++ highcharts/highcharts-modules-no-data-to-display.d.ts | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 highcharts/highcharts-modules-no-data-to-display-tests.ts diff --git a/highcharts/highcharts-modules-no-data-to-display-tests.ts b/highcharts/highcharts-modules-no-data-to-display-tests.ts new file mode 100644 index 0000000000..9b1d69b8da --- /dev/null +++ b/highcharts/highcharts-modules-no-data-to-display-tests.ts @@ -0,0 +1,9 @@ +/// +/// + +function test_NoDataToDisplay() { + var chart = $("#container").highcharts(); + var chartHasData = chart.hasData(); + chart.hideNoData(); + chart.showNoData("Custom no data message"); +} diff --git a/highcharts/highcharts-modules-no-data-to-display.d.ts b/highcharts/highcharts-modules-no-data-to-display.d.ts index 6b8ed03e15..c1429efe78 100644 --- a/highcharts/highcharts-modules-no-data-to-display.d.ts +++ b/highcharts/highcharts-modules-no-data-to-display.d.ts @@ -1,4 +1,4 @@ -/// +// interface HighchartsChartObject { /** * Returns true if there are data points within the plot area now From 6dcc2fe492f45659b4b7d5bda73530c982715c38 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:07:23 +0200 Subject: [PATCH 4/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts-modules-no-data-to-display.d.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/highcharts/highcharts-modules-no-data-to-display.d.ts b/highcharts/highcharts-modules-no-data-to-display.d.ts index c1429efe78..120acede4c 100644 --- a/highcharts/highcharts-modules-no-data-to-display.d.ts +++ b/highcharts/highcharts-modules-no-data-to-display.d.ts @@ -1,3 +1,7 @@ +// Type definitions for Highcharts No Data to Display +// Project: http://www.highcharts.com/ +// Definitions by: Andrey Zolotin +// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // interface HighchartsChartObject { /** From 1234549417e07d3fb1dbb6a269bd2c2e3ff83bb6 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:11:16 +0200 Subject: [PATCH 5/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts-modules-no-data-to-display.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/highcharts/highcharts-modules-no-data-to-display.d.ts b/highcharts/highcharts-modules-no-data-to-display.d.ts index 120acede4c..d1910675cd 100644 --- a/highcharts/highcharts-modules-no-data-to-display.d.ts +++ b/highcharts/highcharts-modules-no-data-to-display.d.ts @@ -2,7 +2,7 @@ // Project: http://www.highcharts.com/ // Definitions by: Andrey Zolotin // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// +// interface HighchartsChartObject { /** * Returns true if there are data points within the plot area now From 1b240acf4a60d678527b4b1099c23ddb255a9752 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:45:11 +0200 Subject: [PATCH 6/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts-modules-no-data-to-display-tests.ts | 2 +- highcharts/highcharts-modules-no-data-to-display.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/highcharts/highcharts-modules-no-data-to-display-tests.ts b/highcharts/highcharts-modules-no-data-to-display-tests.ts index 9b1d69b8da..454b50f067 100644 --- a/highcharts/highcharts-modules-no-data-to-display-tests.ts +++ b/highcharts/highcharts-modules-no-data-to-display-tests.ts @@ -1,4 +1,4 @@ -/// +/// /// function test_NoDataToDisplay() { diff --git a/highcharts/highcharts-modules-no-data-to-display.d.ts b/highcharts/highcharts-modules-no-data-to-display.d.ts index d1910675cd..120acede4c 100644 --- a/highcharts/highcharts-modules-no-data-to-display.d.ts +++ b/highcharts/highcharts-modules-no-data-to-display.d.ts @@ -2,7 +2,7 @@ // Project: http://www.highcharts.com/ // Definitions by: Andrey Zolotin // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// +// interface HighchartsChartObject { /** * Returns true if there are data points within the plot area now From 26a7266dbb029fe0abab4070fe973838d162f937 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:48:36 +0200 Subject: [PATCH 7/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts-modules-no-data-to-display-tests.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/highcharts/highcharts-modules-no-data-to-display-tests.ts b/highcharts/highcharts-modules-no-data-to-display-tests.ts index 454b50f067..5a6ed0b59c 100644 --- a/highcharts/highcharts-modules-no-data-to-display-tests.ts +++ b/highcharts/highcharts-modules-no-data-to-display-tests.ts @@ -1,5 +1,6 @@ /// /// +// function test_NoDataToDisplay() { var chart = $("#container").highcharts(); From c19594e5e5437039b1530114d82a7b022773c01a Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:55:09 +0200 Subject: [PATCH 8/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts-modules-no-data-to-display-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/highcharts/highcharts-modules-no-data-to-display-tests.ts b/highcharts/highcharts-modules-no-data-to-display-tests.ts index 5a6ed0b59c..806b7c3dd8 100644 --- a/highcharts/highcharts-modules-no-data-to-display-tests.ts +++ b/highcharts/highcharts-modules-no-data-to-display-tests.ts @@ -1,6 +1,6 @@ /// -/// // +/// function test_NoDataToDisplay() { var chart = $("#container").highcharts(); From c6b2d3b16c76a52fbff392520d46427f882dad53 Mon Sep 17 00:00:00 2001 From: "Zolotin, Andrey (GGA)" Date: Fri, 12 Aug 2016 16:55:48 +0200 Subject: [PATCH 9/9] #10342 Added hideNoData/showNoData to highcharts --- highcharts/highcharts-modules-no-data-to-display-tests.ts | 2 +- highcharts/highcharts-modules-no-data-to-display.d.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/highcharts/highcharts-modules-no-data-to-display-tests.ts b/highcharts/highcharts-modules-no-data-to-display-tests.ts index 806b7c3dd8..64b50f831f 100644 --- a/highcharts/highcharts-modules-no-data-to-display-tests.ts +++ b/highcharts/highcharts-modules-no-data-to-display-tests.ts @@ -1,5 +1,5 @@ /// -// +/// /// function test_NoDataToDisplay() { diff --git a/highcharts/highcharts-modules-no-data-to-display.d.ts b/highcharts/highcharts-modules-no-data-to-display.d.ts index 120acede4c..ab5fdd1d0d 100644 --- a/highcharts/highcharts-modules-no-data-to-display.d.ts +++ b/highcharts/highcharts-modules-no-data-to-display.d.ts @@ -2,7 +2,7 @@ // Project: http://www.highcharts.com/ // Definitions by: Andrey Zolotin // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -// +/// interface HighchartsChartObject { /** * Returns true if there are data points within the plot area now