From dd4b4bf26c3bf43ea2df913efe70a427969f3731 Mon Sep 17 00:00:00 2001
From: everhardt <rob@everhardt.nl>
Date: Tue, 17 Dec 2019 14:28:52 +0100
Subject: [PATCH] [node] stream: support readable/writableHWM for Duplex
 (#40843)

* stream: support readable/writableHWM for Duplex

see https://github.com/nodejs/node/commit/ef8ac7b5ac04aab3a96e0d6524c016afec321e5b and https://nodejs.org/api/stream.html#stream_new_stream_duplex_options

* [node] stream: support readable/writableHWM for Duplex (2)

Also for v8 and v9

* [node] stream: add tests for readable/writableHWM for Duplex (2)

* Revert "stream: support readable/writableHWM for Duplex" for v8, v9 and v11
---
 types/node/stream.d.ts       | 2 ++
 types/node/test/stream.ts    | 8 ++++++--
 types/node/v10/node-tests.ts | 8 ++++++--
 types/node/v10/stream.d.ts   | 2 ++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/types/node/stream.d.ts b/types/node/stream.d.ts
index 2a0895b0dc..a271af89cd 100644
--- a/types/node/stream.d.ts
+++ b/types/node/stream.d.ts
@@ -210,6 +210,8 @@ declare module "stream" {
             allowHalfOpen?: boolean;
             readableObjectMode?: boolean;
             writableObjectMode?: boolean;
+            readableHighWaterMark?: number;
+            writableHighWaterMark?: number;
             read?(this: Duplex, size: number): void;
             write?(this: Duplex, chunk: any, encoding: string, callback: (error?: Error | null) => void): void;
             writev?(this: Duplex, chunks: Array<{ chunk: any, encoding: string }>, callback: (error?: Error | null) => void): void;
diff --git a/types/node/test/stream.ts b/types/node/test/stream.ts
index 892f5a0fca..b62c7d5aec 100644
--- a/types/node/test/stream.ts
+++ b/types/node/test/stream.ts
@@ -96,7 +96,9 @@ function simplified_stream_ctor_test() {
             cb;
         },
         readableObjectMode: true,
-        writableObjectMode: true
+        writableObjectMode: true,
+        readableHighWaterMark: 2048,
+        writableHighWaterMark: 1024
     });
 
     new Transform({
@@ -154,7 +156,9 @@ function simplified_stream_ctor_test() {
         },
         allowHalfOpen: true,
         readableObjectMode: true,
-        writableObjectMode: true
+        writableObjectMode: true,
+        readableHighWaterMark: 2048,
+        writableHighWaterMark: 1024
     });
 }
 
diff --git a/types/node/v10/node-tests.ts b/types/node/v10/node-tests.ts
index 89372fee3b..0a73d8cda7 100644
--- a/types/node/v10/node-tests.ts
+++ b/types/node/v10/node-tests.ts
@@ -1147,7 +1147,9 @@ function simplified_stream_ctor_test() {
             cb;
         },
         readableObjectMode: true,
-        writableObjectMode: true
+        writableObjectMode: true,
+        readableHighWaterMark: 2048,
+        writableHighWaterMark: 1024
     });
 
     new stream.Transform({
@@ -1205,7 +1207,9 @@ function simplified_stream_ctor_test() {
         },
         allowHalfOpen: true,
         readableObjectMode: true,
-        writableObjectMode: true
+        writableObjectMode: true,
+        readableHighWaterMark: 2048,
+        writableHighWaterMark: 1024
     });
 }
 
diff --git a/types/node/v10/stream.d.ts b/types/node/v10/stream.d.ts
index f8090aedb8..f3fd17dbac 100644
--- a/types/node/v10/stream.d.ts
+++ b/types/node/v10/stream.d.ts
@@ -195,6 +195,8 @@ declare module "stream" {
             allowHalfOpen?: boolean;
             readableObjectMode?: boolean;
             writableObjectMode?: boolean;
+            readableHighWaterMark?: number;
+            writableHighWaterMark?: number;
             read?(this: Duplex, size: number): void;
             write?(this: Duplex, chunk: any, encoding: string, callback: (error?: Error | null) => void): void;
             writev?(this: Duplex, chunks: Array<{ chunk: any, encoding: string }>, callback: (error?: Error | null) => void): void;