From c37f77d05d609c6702164deb78bd6d39e5f7a206 Mon Sep 17 00:00:00 2001 From: Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> Date: Wed, 13 Feb 2019 20:55:48 +0100 Subject: [PATCH] [node] Make SpawnSyncReturns.error optional --- types/cross-spawn/cross-spawn-tests.ts | 2 +- types/node/child_process.d.ts | 2 +- types/node/v10/child_process.d.ts | 2 +- types/node/v8/index.d.ts | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/types/cross-spawn/cross-spawn-tests.ts b/types/cross-spawn/cross-spawn-tests.ts index 6cb36510d8..f6dac4ea72 100644 --- a/types/cross-spawn/cross-spawn-tests.ts +++ b/types/cross-spawn/cross-spawn-tests.ts @@ -8,7 +8,7 @@ pw.on('error', (err: Error) => { console.log(err); }); -const r1: Error = spawn.sync('foo').error; +const r1: Error | undefined = spawn.sync('foo').error; const r2: string[] = spawn.sync('foo').output; const r3: Buffer = spawn.sync('foo').stdout; const r4: Buffer = spawn.sync('foo').stderr; diff --git a/types/node/child_process.d.ts b/types/node/child_process.d.ts index 8e10d4e0c7..cf4c2ed9f7 100644 --- a/types/node/child_process.d.ts +++ b/types/node/child_process.d.ts @@ -285,7 +285,7 @@ declare module "child_process" { stderr: T; status: number; signal: string; - error: Error; + error?: Error; } function spawnSync(command: string): SpawnSyncReturns; function spawnSync(command: string, options?: SpawnSyncOptionsWithStringEncoding): SpawnSyncReturns; diff --git a/types/node/v10/child_process.d.ts b/types/node/v10/child_process.d.ts index c8d20b8249..1114247bee 100644 --- a/types/node/v10/child_process.d.ts +++ b/types/node/v10/child_process.d.ts @@ -293,7 +293,7 @@ declare module "child_process" { stderr: T; status: number; signal: string; - error: Error; + error?: Error; } function spawnSync(command: string): SpawnSyncReturns; function spawnSync(command: string, options?: SpawnSyncOptionsWithStringEncoding): SpawnSyncReturns; diff --git a/types/node/v8/index.d.ts b/types/node/v8/index.d.ts index 1fac090367..94a72711c4 100644 --- a/types/node/v8/index.d.ts +++ b/types/node/v8/index.d.ts @@ -2288,7 +2288,7 @@ declare module "child_process" { stderr: T; status: number; signal: string; - error: Error; + error?: Error; } export function spawnSync(command: string): SpawnSyncReturns; export function spawnSync(command: string, options?: SpawnSyncOptionsWithStringEncoding): SpawnSyncReturns;