From de687655a600198b8b223bc263231ef087e2ff99 Mon Sep 17 00:00:00 2001 From: Jonathan Haines Date: Sat, 4 Apr 2020 04:19:35 +1100 Subject: [PATCH] Ember Data Adapter: export default AdapterError (#43563) * Ember Data Adapter: export default AdapterError The current types use a named export ``` import { AdapterError } from '@ember-data/adapter/error'; ``` compared to what is documented ``` // documented import AdapterError from '@ember-data/adapter/error'; ``` - [x] Use a meaningful title for the pull request. Include the name of the package modified. - [x] Test the change in your own code. (Compile and run.) - [ ] Add or edit tests to reflect the change. (Run with `npm test`.) - [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request). - [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes). - [ ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present). If changing an existing definition: - [x] Provide a URL to documentation or source code which provides context for the suggested changes: * Update error.ts --- types/ember-data__adapter/error.d.ts | 3 ++- types/ember-data__adapter/test/error.ts | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/types/ember-data__adapter/error.d.ts b/types/ember-data__adapter/error.d.ts index d8fbece163..a0c135389f 100644 --- a/types/ember-data__adapter/error.d.ts +++ b/types/ember-data__adapter/error.d.ts @@ -1,6 +1,7 @@ import DS from 'ember-data'; -export import AdapterError = DS.AdapterError; +export default DS.AdapterError; + export import InvalidError = DS.InvalidError; export import UnauthorizedError = DS.UnauthorizedError; export import ForbiddenError = DS.ForbiddenError; diff --git a/types/ember-data__adapter/test/error.ts b/types/ember-data__adapter/test/error.ts index bd937fc1be..7256867c3f 100644 --- a/types/ember-data__adapter/test/error.ts +++ b/types/ember-data__adapter/test/error.ts @@ -22,5 +22,9 @@ class MyInvalid extends InvalidError { } } +const invalid = new MyInvalid(); + +const isInvalid = invalid instanceof AdapterError; // $ExpectType + errorsHashToArray({}); // $ExpectType errorsArrayToHash([]); // $ExpectType<{}>