From 29f659a0793a8206b5f9184cae2fd957d8a08895 Mon Sep 17 00:00:00 2001
From: grandin-j <19411995+grandin-j@users.noreply.github.com>
Date: Mon, 22 Oct 2018 08:36:20 -0700
Subject: [PATCH] Update index.d.ts with callbacks for show/hide

Add missing callback parameter to chrome.pageAction.show and chrome.pageAction.hide per https://developer.chrome.com/extensions/pageAction#method-show
---
 types/chrome/index.d.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/types/chrome/index.d.ts b/types/chrome/index.d.ts
index 49f079e159..ba074550f8 100644
--- a/types/chrome/index.d.ts
+++ b/types/chrome/index.d.ts
@@ -4525,12 +4525,12 @@ declare namespace chrome.pageAction {
      * Shows the page action. The page action is shown whenever the tab is selected.
      * @param tabId The id of the tab for which you want to modify the page action.
      */
-    export function hide(tabId: number): void;
+    export function hide(tabId: number, callback?: () => void): void;
     /**
      * Shows the page action. The page action is shown whenever the tab is selected.
      * @param tabId The id of the tab for which you want to modify the page action.
      */
-    export function show(tabId: number): void;
+    export function show(tabId: number, callback?: () => void): void;
     /** Sets the title of the page action. This is displayed in a tooltip over the page action. */
     export function setTitle(details: TitleDetails): void;
     /** Sets the html document to be opened as a popup when the user clicks on the page action's icon. */