From 483c1ab97d7b0f99c5ff0bb2496e852aaee8f5f2 Mon Sep 17 00:00:00 2001 From: Angelo Ocana Date: Sun, 5 Nov 2017 21:35:52 -0500 Subject: [PATCH 1/2] Ramda: Make partial and partialRight binary fns Change Added to Ramda 0.18.0 Pull Request: https://github.com/ramda/ramda/pull/1433 Upgrade guide: https://github.com/ramda/ramda/issues/1436 --- types/ramda/index.d.ts | 20 +++++++++++--------- types/ramda/ramda-tests.ts | 8 ++++---- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/types/ramda/index.d.ts b/types/ramda/index.d.ts index 2f96611b86..59d2fcf26b 100644 --- a/types/ramda/index.d.ts +++ b/types/ramda/index.d.ts @@ -10,6 +10,7 @@ // Simon Højberg // Charles-Philippe Clermont // Samson Keung +// Angelo Ocana // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.4 @@ -1196,19 +1197,20 @@ declare namespace R { pair(fst: F, snd: S): [F, S]; /** - * Accepts as its arguments a function and any number of values and returns a function that, - * when invoked, calls the original function with all of the values prepended to the - * original function's arguments list. In some libraries this function is named `applyLeft`. + * Takes a function `f` and a list of arguments, and returns a function `g`. + * When applied, `g` returns the result of applying `f` to the arguments + * provided initially followed by the arguments provided to `g`. */ - partial(fn: (...a: any[]) => any, ...args: any[]): (...a: any[]) => any; - partial(fn: (...a: any[]) => T, ...args: any[]): (...a: any[]) => T; + partial(fn: (...a: any[]) => any, args: any[]): (...a: any[]) => any; + partial(fn: (...a: any[]) => T, args: any[]): (...a: any[]) => T; /** - * Accepts as its arguments a function and any number of values and returns a function that, - * when invoked, calls the original function with all of the values appended to the original - * function's arguments list. + * Takes a function `f` and a list of arguments, and returns a function `g`. + * When applied, `g` returns the result of applying `f` to the arguments + * provided to `g` followed by the arguments provided initially. */ - partialRight(fn: (...a: any[]) => any, ...args: any[]): (...a: any[]) => any; + partialRight(fn: (...a: any[]) => any, args: any[]): (...a: any[]) => any; + partialRight(fn: (...a: any[]) => T, args: any[]): (...a: any[]) => T; /** * Takes a predicate and a list and returns the pair of lists of elements diff --git a/types/ramda/ramda-tests.ts b/types/ramda/ramda-tests.ts index 3767109e8e..ddaf6d95b1 100644 --- a/types/ramda/ramda-tests.ts +++ b/types/ramda/ramda-tests.ts @@ -266,18 +266,18 @@ R.times(i, 5); return a * b; } - const double = R.partial(multiply, 2); + const double = R.partial(multiply, [2]); double(2); // => 4 function greet(salutation: string, title: string, firstName: string, lastName: string) { return `${salutation}, ${title} ${firstName} ${lastName}!`; } - const sayHello = R.partial(greet, "Hello"); - const sayHelloToMs = R.partial(sayHello, "Ms."); + const sayHello = R.partial(greet, ["Hello"]); + const sayHelloToMs = R.partial(sayHello, ["Ms."]); sayHelloToMs("Jane", "Jones"); // => 'Hello, Ms. Jane Jones!' - const greetMsJaneJones = R.partialRight(greet, "Ms.", "Jane", "Jones"); + const greetMsJaneJones = R.partialRight(greet, ["Ms.", "Jane", "Jones"]); greetMsJaneJones("Hello"); // => 'Hello, Ms. Jane Jones!' })(); From dd669cd78bc4c6dfd6d6fc22dc061e76abf571bf Mon Sep 17 00:00:00 2001 From: Angelo Ocana Date: Mon, 6 Nov 2017 10:29:25 -0500 Subject: [PATCH 2/2] Ramda: Remove return Any for partial/partialRight Remove return **Any** signature for **partial** and **partialRight** as asked by @samsonkeung https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21262/files/483c1ab97d7b0f99c5ff0bb2496e852aaee8f5f2#r148995006 https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21262/files/483c1ab97d7b0f99c5ff0bb2496e852aaee8f5f2#r148995018 --- types/ramda/index.d.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/types/ramda/index.d.ts b/types/ramda/index.d.ts index 59d2fcf26b..5875b4ef50 100644 --- a/types/ramda/index.d.ts +++ b/types/ramda/index.d.ts @@ -1201,7 +1201,6 @@ declare namespace R { * When applied, `g` returns the result of applying `f` to the arguments * provided initially followed by the arguments provided to `g`. */ - partial(fn: (...a: any[]) => any, args: any[]): (...a: any[]) => any; partial(fn: (...a: any[]) => T, args: any[]): (...a: any[]) => T; /** @@ -1209,7 +1208,6 @@ declare namespace R { * When applied, `g` returns the result of applying `f` to the arguments * provided to `g` followed by the arguments provided initially. */ - partialRight(fn: (...a: any[]) => any, args: any[]): (...a: any[]) => any; partialRight(fn: (...a: any[]) => T, args: any[]): (...a: any[]) => T; /**