From e26aaaedb26cc2f42ee65a299c1be20f44fc62b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Szabo?= Date: Tue, 31 Mar 2020 02:13:49 +0200 Subject: [PATCH] fix(eslint): missing static method/property on CLIEngine (#43345) * fix(eslint): missing static method/property - change `CLIEngine.version` to static property - add `CLIEngine.getFormatter` static method * fix(eslint): change let to const in tests * refactor(eslint): revert formatting --- types/eslint/eslint-tests.ts | 5 +++++ types/eslint/index.d.ts | 4 +++- types/eslint/ts3.1/eslint-tests.ts | 5 +++++ types/eslint/ts3.1/index.d.ts | 4 +++- 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/types/eslint/eslint-tests.ts b/types/eslint/eslint-tests.ts index 283f67103a..f654773e87 100644 --- a/types/eslint/eslint-tests.ts +++ b/types/eslint/eslint-tests.ts @@ -547,8 +547,13 @@ data = {rulesMeta: {"no-extra-semi": meta}}; formatter(cliReport.results); formatter(cliReport.results, data); +const version: string = CLIEngine.version; + CLIEngine.getErrorResults(cliReport.results); +formatter = CLIEngine.getFormatter(); +formatter = CLIEngine.getFormatter('codeframe'); + CLIEngine.outputFixes(cliReport); cliReport.errorCount = 0; diff --git a/types/eslint/index.d.ts b/types/eslint/index.d.ts index f19ae6aa93..3f69cc9222 100644 --- a/types/eslint/index.d.ts +++ b/types/eslint/index.d.ts @@ -474,7 +474,7 @@ export namespace Linter { //#region CLIEngine export class CLIEngine { - version: string; + static version: string; constructor(options: CLIEngine.Options); @@ -496,6 +496,8 @@ export class CLIEngine { static getErrorResults(results: CLIEngine.LintResult[]): CLIEngine.LintResult[]; + static getFormatter(format?: string): CLIEngine.Formatter; + static outputFixes(report: CLIEngine.LintReport): void; } diff --git a/types/eslint/ts3.1/eslint-tests.ts b/types/eslint/ts3.1/eslint-tests.ts index a283eca1af..d2531f09ed 100644 --- a/types/eslint/ts3.1/eslint-tests.ts +++ b/types/eslint/ts3.1/eslint-tests.ts @@ -547,8 +547,13 @@ data = {rulesMeta: {"no-extra-semi": meta}}; formatter(cliReport.results); formatter(cliReport.results, data); +const version: string = CLIEngine.version; + CLIEngine.getErrorResults(cliReport.results); +formatter = CLIEngine.getFormatter(); +formatter = CLIEngine.getFormatter('codeframe'); + CLIEngine.outputFixes(cliReport); cliReport.errorCount = 0; diff --git a/types/eslint/ts3.1/index.d.ts b/types/eslint/ts3.1/index.d.ts index ab598f8886..5fe80264d3 100644 --- a/types/eslint/ts3.1/index.d.ts +++ b/types/eslint/ts3.1/index.d.ts @@ -470,7 +470,7 @@ export namespace Linter { //#region CLIEngine export class CLIEngine { - version: string; + static version: string; constructor(options: CLIEngine.Options); @@ -492,6 +492,8 @@ export class CLIEngine { static getErrorResults(results: CLIEngine.LintResult[]): CLIEngine.LintResult[]; + static getFormatter(format?: string): CLIEngine.Formatter; + static outputFixes(report: CLIEngine.LintReport): void; }