From 8cfc13e69d84f67884ee55785af75f085b089655 Mon Sep 17 00:00:00 2001 From: mayerwin Date: Mon, 21 Nov 2016 01:13:40 +0800 Subject: [PATCH 1/2] Update react-select.d.ts Typescript supported way for nested classes as per http://stackoverflow.com/questions/13495107/any-way-to-declare-a-nest-class-structure-in-typescript. Fixes https://github.com/DefinitelyTyped/DefinitelyTyped/issues/12302 --- react-select/react-select.d.ts | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/react-select/react-select.d.ts b/react-select/react-select.d.ts index c50d5f6883..922bd33cae 100644 --- a/react-select/react-select.d.ts +++ b/react-select/react-select.d.ts @@ -5,7 +5,7 @@ /// -declare namespace ReactSelect { +declare namespace ReactSelectNameSpace { interface AutocompleteResult { /** the search-results to be displayed */ @@ -424,28 +424,28 @@ declare namespace ReactSelect { shouldKeyDownEventCreateNewOption?: (arg: { keyCode: number }) => boolean; } - class ReactSelectCreatableClass extends __React.Component { - } - class ReactSelectAsyncClass extends __React.Component { - } class ReactSelectClass extends __React.Component { - static Async: ReactSelectAsyncClass; - static Creatable: ReactSelectCreatableClass; } + module ReactSelectClass { + class Creatable extends __React.Component { + } + class Async extends __React.Component { + } + } } declare module "react-select" { - export = ReactSelect.ReactSelectClass; + export = ReactSelectNameSpace.ReactSelectClass; } declare module "react-select-props" { - import Option = ReactSelect.Option; - import MenuRendererProps = ReactSelect.MenuRendererProps; - import ReactSelectProps = ReactSelect.ReactSelectProps; - import ReactAsyncSelectProps = ReactSelect.ReactAsyncSelectProps; - import ReactCreatableSelectProps = ReactSelect.ReactCreatableSelectProps; + import Option = ReactSelectNameSpace.Option; + import MenuRendererProps = ReactSelectNameSpace.MenuRendererProps; + import ReactSelectProps = ReactSelectNameSpace.ReactSelectProps; + import ReactAsyncSelectProps = ReactSelectNameSpace.ReactAsyncSelectProps; + import ReactCreatableSelectProps = ReactSelectNameSpace.ReactCreatableSelectProps; export { MenuRendererProps, ReactSelectProps, ReactAsyncSelectProps, ReactCreatableSelectProps, Option }; } From 033ce83a65cb06607549af7a2145f99f7aeaeeaa Mon Sep 17 00:00:00 2001 From: mayerwin Date: Mon, 21 Nov 2016 10:02:45 +0800 Subject: [PATCH 2/2] Update react-select.d.ts Revert namespace name change --- react-select/react-select.d.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/react-select/react-select.d.ts b/react-select/react-select.d.ts index 922bd33cae..e3a756147c 100644 --- a/react-select/react-select.d.ts +++ b/react-select/react-select.d.ts @@ -5,7 +5,7 @@ /// -declare namespace ReactSelectNameSpace { +declare namespace ReactSelect { interface AutocompleteResult { /** the search-results to be displayed */ @@ -436,16 +436,16 @@ declare namespace ReactSelectNameSpace { } declare module "react-select" { - export = ReactSelectNameSpace.ReactSelectClass; + export = ReactSelect.ReactSelectClass; } declare module "react-select-props" { - import Option = ReactSelectNameSpace.Option; - import MenuRendererProps = ReactSelectNameSpace.MenuRendererProps; - import ReactSelectProps = ReactSelectNameSpace.ReactSelectProps; - import ReactAsyncSelectProps = ReactSelectNameSpace.ReactAsyncSelectProps; - import ReactCreatableSelectProps = ReactSelectNameSpace.ReactCreatableSelectProps; + import Option = ReactSelect.Option; + import MenuRendererProps = ReactSelect.MenuRendererProps; + import ReactSelectProps = ReactSelect.ReactSelectProps; + import ReactAsyncSelectProps = ReactSelect.ReactAsyncSelectProps; + import ReactCreatableSelectProps = ReactSelect.ReactCreatableSelectProps; export { MenuRendererProps, ReactSelectProps, ReactAsyncSelectProps, ReactCreatableSelectProps, Option }; }