From 84a5437c97f3ff4f60b175863f8c4133c5606da9 Mon Sep 17 00:00:00 2001 From: Sarah Sporck Date: Mon, 12 Mar 2018 14:32:35 +0100 Subject: [PATCH 1/2] added modify to knex QueryInterface --- types/knex/index.d.ts | 1 + types/knex/knex-tests.ts | 3 +++ 2 files changed, 4 insertions(+) diff --git a/types/knex/index.d.ts b/types/knex/index.d.ts index eecfde8774..4dcbab481b 100644 --- a/types/knex/index.d.ts +++ b/types/knex/index.d.ts @@ -153,6 +153,7 @@ declare namespace Knex { pluck(column: string): QueryBuilder; insert(data: any, returning?: string | string[]): QueryBuilder; + modify(callback: QueryCallback): QueryBuilder; update(data: any, returning?: string | string[]): QueryBuilder; update(columnName: string, value: Value, returning?: string | string[]): QueryBuilder; returning(column: string | string[]): QueryBuilder; diff --git a/types/knex/knex-tests.ts b/types/knex/knex-tests.ts index 3e8e798212..dae9bf66fc 100644 --- a/types/knex/knex-tests.ts +++ b/types/knex/knex-tests.ts @@ -1026,6 +1026,9 @@ knex('users') }).unionAll(function(builder) { let self: Knex.QueryBuilder = this; self = builder; + }).modify(function(builder) { + let self: Knex.QueryBuilder = this; + self = builder; }); // From 302450b880881d7519cfa2bcd0f5eed912a0dff8 Mon Sep 17 00:00:00 2001 From: Sarah Date: Thu, 15 Mar 2018 17:35:02 +0100 Subject: [PATCH 2/2] added optional aruments --- types/knex/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/knex/index.d.ts b/types/knex/index.d.ts index 4dcbab481b..64f813c5b7 100644 --- a/types/knex/index.d.ts +++ b/types/knex/index.d.ts @@ -153,7 +153,7 @@ declare namespace Knex { pluck(column: string): QueryBuilder; insert(data: any, returning?: string | string[]): QueryBuilder; - modify(callback: QueryCallback): QueryBuilder; + modify(callback: QueryCallback, ...args: any[]): QueryBuilder; update(data: any, returning?: string | string[]): QueryBuilder; update(columnName: string, value: Value, returning?: string | string[]): QueryBuilder; returning(column: string | string[]): QueryBuilder;