From f0a1ca6c97d2d63fe5f9433fbe8dea312eef486f Mon Sep 17 00:00:00 2001 From: Tom Crockett Date: Thu, 21 Nov 2013 00:43:58 -0800 Subject: [PATCH 1/5] Add color component fields for other color spaces besides RGB --- d3/d3.d.ts | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/d3/d3.d.ts b/d3/d3.d.ts index 382a958758..ef7f1da722 100644 --- a/d3/d3.d.ts +++ b/d3/d3.d.ts @@ -1414,6 +1414,18 @@ declare module D3 { } export interface HSLColor extends Color{ + /** + * hue + */ + h: number; + /** + * saturation + */ + s: number; + /** + * lightness + */ + l: number; /** * convert from HSL to RGB. */ @@ -1421,6 +1433,18 @@ declare module D3 { } export interface LABColor extends Color{ + /** + * lightness + */ + l: number; + /** + * a-dimension + */ + a: number; + /** + * b-dimension + */ + b: number; /** * convert from LAB to RGB. */ @@ -1428,6 +1452,18 @@ declare module D3 { } export interface HCLColor extends Color{ + /** + * hue + */ + h: number; + /** + * chroma + */ + c: number; + /** + * luminance + */ + l: number; /** * convert from HCL to RGB. */ From e5ef1afbee679a62f352d1c8ab992566ead11395 Mon Sep 17 00:00:00 2001 From: Tom Crockett Date: Thu, 21 Nov 2013 00:44:23 -0800 Subject: [PATCH 2/5] Fix comment typo --- d3/d3.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d3/d3.d.ts b/d3/d3.d.ts index ef7f1da722..483319efdf 100644 --- a/d3/d3.d.ts +++ b/d3/d3.d.ts @@ -1400,7 +1400,7 @@ declare module D3 { */ r: number; /** - * the greeb color channel. + * the green color channel. */ g: number; /** From 2c47116ce6a87cac822ffb93cadc090c06e7cfd1 Mon Sep 17 00:00:00 2001 From: Tom Crockett Date: Thu, 21 Nov 2013 00:56:28 -0800 Subject: [PATCH 3/5] Add method for obtaining UTC TimeScale --- d3/d3.d.ts | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/d3/d3.d.ts b/d3/d3.d.ts index 483319efdf..7facd86758 100644 --- a/d3/d3.d.ts +++ b/d3/d3.d.ts @@ -944,7 +944,18 @@ declare module D3 { iso: TimeFormat; }; - scale(): Scale.TimeScale; + scale: { + /** + * Constructs a new time scale with the default domain and range; + * the ticks and tick format are configured for local time. + */ + (): Scale.TimeScale; + /** + * Constructs a new time scale with the default domain and range; + * the ticks and tick format are configured for UTC time. + */ + utc(): Scale.TimeScale; + }; } export interface Range { From b9434af57b86d2b914c820f17d7d506c1c0a9f3f Mon Sep 17 00:00:00 2001 From: Tom Crockett Date: Thu, 21 Nov 2013 01:12:15 -0800 Subject: [PATCH 4/5] Fix the type of Zoom application --- d3/d3.d.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/d3/d3.d.ts b/d3/d3.d.ts index 7facd86758..67cc268ae1 100644 --- a/d3/d3.d.ts +++ b/d3/d3.d.ts @@ -2681,9 +2681,11 @@ declare module D3 { export interface Zoom { /** - * Execute zoom method + * Applies the zoom behavior to the specified selection, + * registering the necessary event listeners to support + * panning and zooming. */ - (): any; + (Selection): void; /** * Registers a listener to receive events From d7ad31ba431829f227fb45d20dcb7952b59d9d6d Mon Sep 17 00:00:00 2001 From: Tom Crockett Date: Thu, 21 Nov 2013 02:53:57 -0800 Subject: [PATCH 5/5] Add missing formal parameter name --- d3/d3.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d3/d3.d.ts b/d3/d3.d.ts index 67cc268ae1..daa53f67c5 100644 --- a/d3/d3.d.ts +++ b/d3/d3.d.ts @@ -2685,7 +2685,7 @@ declare module D3 { * registering the necessary event listeners to support * panning and zooming. */ - (Selection): void; + (selection: Selection): void; /** * Registers a listener to receive events