From e72e9ce4968d67310b2713d1afa700cccefe372b Mon Sep 17 00:00:00 2001 From: denis Date: Wed, 12 Sep 2018 12:09:43 +0200 Subject: [PATCH] d3-request strictFunctionTypes --- types/d3-request/d3-request-tests.ts | 8 ++++---- types/d3-request/tsconfig.json | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/types/d3-request/d3-request-tests.ts b/types/d3-request/d3-request-tests.ts index e2208481d8..1a8c7be647 100644 --- a/types/d3-request/d3-request-tests.ts +++ b/types/d3-request/d3-request-tests.ts @@ -350,7 +350,7 @@ let csvRequest: d3Request.DsvRequest = d3Request.csv(url); // url and callback for response handling const csvRequestWithCallback: d3Request.DsvRequest = d3Request.csv(url, function(error, data) { - const that: d3Request.Request = this; + const that: d3Request.DsvRequest = this; const err: any = error; const d: DSVParsedArray = data; console.log(d); @@ -369,7 +369,7 @@ const csvRequestWithRowWithCallback: d3Request.DsvRequest = d3Request.csv = data; console.log(data); @@ -384,7 +384,7 @@ const tsvRequest: d3Request.DsvRequest = d3Request.tsv(url); // url and callback for response handling const tsvRequestWithCallback: d3Request.DsvRequest = d3Request.tsv(url, function(error, data) { - const that: d3Request.Request = this; + const that: d3Request.DsvRequest = this; const err: any = error; const d: DSVParsedArray = data; console.log(d); @@ -403,7 +403,7 @@ const tsvRequestWithRowWithCallback: d3Request.DsvRequest = d3Request.tsv = data; console.log(data); diff --git a/types/d3-request/tsconfig.json b/types/d3-request/tsconfig.json index 9ba2eb33f3..844ff6991e 100644 --- a/types/d3-request/tsconfig.json +++ b/types/d3-request/tsconfig.json @@ -8,7 +8,7 @@ "noImplicitAny": true, "noImplicitThis": true, "strictNullChecks": true, - "strictFunctionTypes": false, + "strictFunctionTypes": true, "baseUrl": "../", "typeRoots": [ "../"