vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2026-01-30 21:47:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make cache-manager tests strictNullChecks safe (#42686)

Browse Source 
The new code in cache-manager wasn't strictNullChecks safe, which caused
problems because a community member enabled strictNullChecks in most
packages during the review period for that code.

This change just fixes the tests, although the optional methods on Store
are a bit suspicious. From skimming cache-manager's documentation, I
couldn't figure out if having the methods be optional was accurate.
This commit is contained in:
Nathan Shively-Sanders 2020-02-27 09:50:39 -08:00 committed by GitHub
parent e1f3734de2
commit e7e259f3fe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
types/cache-manager/cache-manager-tests.ts
View File

@ -49,10 +49,11 @@ memoryCache.wrap<{ id: number, name: string }>(key, (cb: any) => {
});
});
memoryCache.store.keys().then((result) => {
//console.log(result);
});
if (memoryCache.store.keys) {
memoryCache.store.keys().then((result) => {
//console.log(result);
});
}
const multiCache = cacheManager.multiCaching([memoryCache]);