From 9f40f31e03a0e0da8cef651744bcd94a4470c86e Mon Sep 17 00:00:00 2001 From: "Pecinka, Libor" Date: Mon, 24 Sep 2018 12:07:34 +0200 Subject: [PATCH 1/3] currSlide type changed from jQuery to newly added interface RoyalSliderSlide --- types/royalslider/index.d.ts | 69 +++++++++++++++++++++++++++++++++++- 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/types/royalslider/index.d.ts b/types/royalslider/index.d.ts index 5fc9abe068..2167e10151 100644 --- a/types/royalslider/index.d.ts +++ b/types/royalslider/index.d.ts @@ -366,6 +366,73 @@ declare namespace RoyalSlider { */ visibleNearby?: RoyalSliderVisibleOptions; } + + export interface RoyalSliderSlide { + /** + * TODO + */ + appendOnLoaded: boolean; + /** + * slide element + */ + content: JQuery; + /** + * TODO + */ + contentAdded: boolean; + /** + * slide element wrapper + */ + holder: JQuery; + /** + * slide index + */ + id: number; + /** + * TODO + */ + images: null; + /** + * TODO + */ + isAdded: boolean; + /** + * TODO + */ + isAppended: boolean; + /** + * TODO + */ + isBig: boolean; + /** + * TODO + */ + isLoaded: boolean; + /** + * TODO + */ + isLoading: boolean; + /** + * TODO + */ + isRendered: boolean; + /** + * TODO + */ + loadedTriggered: boolean; + /** + * TODO + */ + positionSet: boolean; + /** + * TODO + */ + sizeReady: boolean; + /** + * TODO + */ + thumbnail: string; + } export interface RoyalSlider { //TODO: extends/implements JQuery? (giving problems due to next(), prev(), width and height and 'selector'. /** @@ -443,7 +510,7 @@ declare namespace RoyalSlider { /** * current slide object */ - currSlide: JQuery; + currSlide: RoyalSliderSlide; /** * total number of slides */ From 3492bc451662597795f47ababb19a45defcb8de9 Mon Sep 17 00:00:00 2001 From: "Pecinka, Libor" Date: Mon, 24 Sep 2018 13:42:34 +0200 Subject: [PATCH 2/3] slides type changed from any[] to RoyalSliderSlide[] --- types/royalslider/index.d.ts | 138 +++++++++++++++++------------------ 1 file changed, 69 insertions(+), 69 deletions(-) diff --git a/types/royalslider/index.d.ts b/types/royalslider/index.d.ts index 2167e10151..d6fd02075a 100644 --- a/types/royalslider/index.d.ts +++ b/types/royalslider/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for jQuery royal-slider 9.4 // Project: http://dimsemenov.com/plugins/royal-slider/documentation/ -// Definitions by: Christiaan Rakowski +// Definitions by: Christiaan Rakowski , sKopheK // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -366,73 +366,73 @@ declare namespace RoyalSlider { */ visibleNearby?: RoyalSliderVisibleOptions; } - - export interface RoyalSliderSlide { - /** - * TODO - */ - appendOnLoaded: boolean; - /** - * slide element - */ - content: JQuery; - /** - * TODO - */ - contentAdded: boolean; - /** - * slide element wrapper - */ - holder: JQuery; - /** - * slide index - */ - id: number; - /** - * TODO - */ - images: null; - /** - * TODO - */ - isAdded: boolean; - /** - * TODO - */ - isAppended: boolean; - /** - * TODO - */ - isBig: boolean; - /** - * TODO - */ - isLoaded: boolean; - /** - * TODO - */ - isLoading: boolean; - /** - * TODO - */ - isRendered: boolean; - /** - * TODO - */ - loadedTriggered: boolean; - /** - * TODO - */ - positionSet: boolean; - /** - * TODO - */ - sizeReady: boolean; - /** - * TODO - */ - thumbnail: string; - } + + export interface RoyalSliderSlide { + /** + * TODO + */ + appendOnLoaded: boolean; + /** + * slide element + */ + content: JQuery; + /** + * TODO + */ + contentAdded: boolean; + /** + * slide element wrapper + */ + holder: JQuery; + /** + * slide index + */ + id: number; + /** + * TODO + */ + images: null; + /** + * TODO + */ + isAdded: boolean; + /** + * TODO + */ + isAppended: boolean; + /** + * TODO + */ + isBig: boolean; + /** + * TODO + */ + isLoaded: boolean; + /** + * TODO + */ + isLoading: boolean; + /** + * TODO + */ + isRendered: boolean; + /** + * TODO + */ + loadedTriggered: boolean; + /** + * TODO + */ + positionSet: boolean; + /** + * TODO + */ + sizeReady: boolean; + /** + * TODO + */ + thumbnail: string; + } export interface RoyalSlider { //TODO: extends/implements JQuery? (giving problems due to next(), prev(), width and height and 'selector'. /** @@ -538,7 +538,7 @@ declare namespace RoyalSlider { /** * contains all data about each slide */ - slides: any[]; //TODO: what type? + slides: RoyalSliderSlide[]; /** * Contains list of HTML slides that are added to slider */ From 873dd39d02d5f8d53a422e1368483cb846cd1d9d Mon Sep 17 00:00:00 2001 From: "Pecinka, Libor" Date: Mon, 24 Sep 2018 14:19:28 +0200 Subject: [PATCH 3/3] Definitions by URL fix --- types/royalslider/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/royalslider/index.d.ts b/types/royalslider/index.d.ts index d6fd02075a..e736709b82 100644 --- a/types/royalslider/index.d.ts +++ b/types/royalslider/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for jQuery royal-slider 9.4 // Project: http://dimsemenov.com/plugins/royal-slider/documentation/ -// Definitions by: Christiaan Rakowski , sKopheK +// Definitions by: Christiaan Rakowski , sKopheK // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3