From e87f5a9181d76fc725ff7f5d1fb37a3ad1342b8e Mon Sep 17 00:00:00 2001 From: katashin Date: Thu, 28 Mar 2019 08:00:00 +0800 Subject: [PATCH] [twilio-video] Add missing ConnectOptions parameters (#34057) * Add missing ConnectOptions parameters in twilio-video * Update definitions by on twilio-video --- types/twilio-video/index.d.ts | 6 +++++- types/twilio-video/twilio-video-tests.ts | 8 +++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/types/twilio-video/index.d.ts b/types/twilio-video/index.d.ts index 9b1d483987..2a63736a4a 100644 --- a/types/twilio-video/index.d.ts +++ b/types/twilio-video/index.d.ts @@ -1,6 +1,8 @@ // Type definitions for twilio-video 2.0 // Project: https://twilio.com/video, https://twilio.com -// Definitions by: MindDoc , Darío Blanco +// Definitions by: MindDoc +// Darío Blanco +// katashin // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -469,6 +471,7 @@ export type AudioTrackPublication = LocalAudioTrackPublication | RemoteAudioTrac export interface ConnectOptions { abortOnIceServersTimeout?: boolean; audio?: boolean | CreateLocalTrackOptions; + dominantSpeaker?: boolean; iceServers?: RTCIceServer[]; iceServersTimeout?: number; iceTransportPolicy?: RTCIceTransportPolicy; @@ -476,6 +479,7 @@ export interface ConnectOptions { maxAudioBitRate?: number | null; maxVideoBitRate?: number | null; name?: string | null; + networkQuality?: boolean; preferredAudioCodecs?: AudioCodec[]; preferredVideoCodecs?: VideoCodec[] | VideoCodecSettings[]; logLevel?: LogLevel | LogLevels; diff --git a/types/twilio-video/twilio-video-tests.ts b/types/twilio-video/twilio-video-tests.ts index 12291e9555..9407bed52b 100644 --- a/types/twilio-video/twilio-video-tests.ts +++ b/types/twilio-video/twilio-video-tests.ts @@ -8,7 +8,13 @@ let localAudioTrack: Video.LocalAudioTrack | null = null; async function initRoom() { // Connect to Twilio without creating audio and video track - room = await Video.connect('$TOKEN', { name: 'room-name', video: false, audio: false }); + room = await Video.connect('$TOKEN', { + name: 'room-name', + video: false, + audio: false, + dominantSpeaker: true, + networkQuality: true + }); // Create local video track from default input localVideoTrack = await Video.createLocalVideoTrack({ name: 'camera' }); // Create local audio track from default input