From 0514660017f931e31d84de41929a385a8330ecd5 Mon Sep 17 00:00:00 2001 From: Andrey Kurdyumov Date: Wed, 23 Nov 2016 12:40:31 +0600 Subject: [PATCH 1/2] Add missing onError See http://knockoutjs.com/documentation/asynchronous-error-handling.html for justification --- knockout/index.d.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/knockout/index.d.ts b/knockout/index.d.ts index 3db35f7578..a4ca8573ae 100644 --- a/knockout/index.d.ts +++ b/knockout/index.d.ts @@ -587,6 +587,12 @@ interface KnockoutStatic { ///////////////////////////////// tasks: KnockoutTasks; + + ///////////////////////////////// + // utils.js + ///////////////////////////////// + + onError: (error: Error) => any; } interface KnockoutBindingProvider { From 19a466bce5b2b3419f355491fdf273f5c56bdb7b Mon Sep 17 00:00:00 2001 From: Andrey Kyrdyumov Date: Thu, 24 Nov 2016 10:01:15 +0600 Subject: [PATCH 2/2] Make strickter onError signature and make it optional --- knockout/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/knockout/index.d.ts b/knockout/index.d.ts index a4ca8573ae..970a4e9a08 100644 --- a/knockout/index.d.ts +++ b/knockout/index.d.ts @@ -592,7 +592,7 @@ interface KnockoutStatic { // utils.js ///////////////////////////////// - onError: (error: Error) => any; + onError?: (error: Error) => void; } interface KnockoutBindingProvider {