From 5d5aaa8b7a0b4e8e1b6efc42d55fb773ae6030ac Mon Sep 17 00:00:00 2001 From: Tim Chen Date: Sat, 3 Feb 2018 18:52:11 -0500 Subject: [PATCH 1/2] Player should be the default export --- types/vimeo__player/index.d.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/types/vimeo__player/index.d.ts b/types/vimeo__player/index.d.ts index 3712e20cf7..c2699d15d2 100755 --- a/types/vimeo__player/index.d.ts +++ b/types/vimeo__player/index.d.ts @@ -1,6 +1,8 @@ // Type definitions for @vimeo/player 2.0 // Project: https://github.com/vimeo/player.js -// Definitions by: Denis Yılmaz , Felix Albert +// Definitions by: Denis Yılmaz +// Felix Albert +// Tim Chen // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped export function myMethod(a: string): string; @@ -23,7 +25,7 @@ export interface TypeError extends Error {name: "TypeError"; message: string; me export type EventName = "play" | "pause" | "ended" | "timeupdate" | "progress" | "seeked" | "texttrackchange" | "cuechange" | "cuepoint" | "volumechange" | "error" | "loaded" | string; export type EventCallback = (data: any) => any; -export class Player { +export default class Player { constructor(element: HTMLIFrameElement|HTMLElement|string, options: Options); on(event: EventName, callback: EventCallback): void; From 255933f96afde10d8a7f477fe10e0cf9f4f5a2bb Mon Sep 17 00:00:00 2001 From: Tim Chen Date: Sat, 3 Feb 2018 19:29:23 -0500 Subject: [PATCH 2/2] fix test --- types/vimeo__player/vimeo__player-tests.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/vimeo__player/vimeo__player-tests.ts b/types/vimeo__player/vimeo__player-tests.ts index 622d5ca339..bf5a637762 100644 --- a/types/vimeo__player/vimeo__player-tests.ts +++ b/types/vimeo__player/vimeo__player-tests.ts @@ -1,4 +1,4 @@ -import { Player } from '@vimeo/player'; +import Player from '@vimeo/player'; // based on README.md of @vimeo/player >> https://github.com/vimeo/player.js