From 7d11f19e7f81ff064b323e640c55886bb773099a Mon Sep 17 00:00:00 2001 From: 0x6368656174 <0x6368656174@gmail.com> Date: Wed, 20 Dec 2017 15:13:15 +1000 Subject: [PATCH 1/3] Change Siema import and fix typings --- types/siema/index.d.ts | 16 ++++++++-------- types/siema/siema-tests.ts | 11 +++++++---- types/siema/tsconfig.json | 5 +++-- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/types/siema/index.d.ts b/types/siema/index.d.ts index 682c0e907e..09762fb7ac 100644 --- a/types/siema/index.d.ts +++ b/types/siema/index.d.ts @@ -1,8 +1,10 @@ // Type definitions for siema 1.4 // Project: https://github.com/pawelgrzybek/siema // Definitions by: Irmantas Zenkus +// Pavel Puchkov // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped -declare class Siema { + +export default class Siema { currentSlide: number; constructor(options?: SiemaOptions); @@ -11,13 +13,13 @@ declare class Siema { prev(index?: number, callback?: () => void): void; goTo(index: number, callback?: () => void): void; remove(index: number, callback?: () => void): void; - insert(item: any, index: number, callback?: () => void): void; - prepend(item: any, callback?: () => void): void; - append(item: any, callback?: () => void): void; - destroy(restoreMarkup: boolean, callback?: () => void): void; + insert(item: HTMLElement, index: number, callback?: () => void): void; + prepend(item: HTMLElement, callback?: () => void): void; + append(item: HTMLElement, callback?: () => void): void; + destroy(restoreMarkup?: boolean, callback?: () => void): void; } -interface SiemaOptions { +export interface SiemaOptions { selector?: string; duration?: number; easing?: string; @@ -30,5 +32,3 @@ interface SiemaOptions { onInit(): void; onChange?(): void; } - -export = Siema; diff --git a/types/siema/siema-tests.ts b/types/siema/siema-tests.ts index c8d9e755b2..61635ce5a3 100644 --- a/types/siema/siema-tests.ts +++ b/types/siema/siema-tests.ts @@ -1,4 +1,4 @@ -import Siema = require('siema'); +import Siema from 'siema'; const siema = new Siema({ selector: '.siema', @@ -14,11 +14,14 @@ const siema = new Siema({ onChange: () => {}, }); +const elem = new HTMLDivElement(); + siema.next(); siema.prev(); siema.goTo(siema.currentSlide); siema.remove(0, () => {}); -siema.insert('item', 0, () => {}); -siema.prepend('item', () => {}); -siema.append('item', () => {}); +siema.insert(elem, 0, () => {}); +siema.prepend(elem, () => {}); +siema.append(elem, () => {}); +siema.destroy(); siema.destroy(true, () => {}); diff --git a/types/siema/tsconfig.json b/types/siema/tsconfig.json index 4fe63d2a73..035dfc51d0 100644 --- a/types/siema/tsconfig.json +++ b/types/siema/tsconfig.json @@ -2,7 +2,8 @@ "compilerOptions": { "module": "commonjs", "lib": [ - "es6" + "es6", + "dom" ], "noImplicitAny": true, "noImplicitThis": true, @@ -20,4 +21,4 @@ "index.d.ts", "siema-tests.ts" ] -} \ No newline at end of file +} From 31248d48639db4a5adf748328fa968bcc4a86783 Mon Sep 17 00:00:00 2001 From: 0x6368656174 <0x6368656174@gmail.com> Date: Wed, 20 Dec 2017 15:18:34 +1000 Subject: [PATCH 2/3] change onInit() to optional --- types/siema/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/siema/index.d.ts b/types/siema/index.d.ts index 09762fb7ac..f323f4e619 100644 --- a/types/siema/index.d.ts +++ b/types/siema/index.d.ts @@ -29,6 +29,6 @@ export interface SiemaOptions { multipleDrag?: boolean; threshold?: number; loop?: boolean; - onInit(): void; + onInit?(): void; onChange?(): void; } From e8dd3f5ab1f3588a362de73c0081e7f7c53de094 Mon Sep 17 00:00:00 2001 From: 0x6368656174 <0x6368656174@gmail.com> Date: Sun, 24 Dec 2017 16:34:12 +1000 Subject: [PATCH 3/3] remove I prefix --- types/siema/index.d.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/types/siema/index.d.ts b/types/siema/index.d.ts index 6da4178e9b..8c1739d58c 100644 --- a/types/siema/index.d.ts +++ b/types/siema/index.d.ts @@ -8,7 +8,7 @@ export default class Siema { currentSlide: number; - constructor(options?: ISiemaOptions); + constructor(options?: SiemaOptions); next(index?: number, callback?: () => void): void; prev(index?: number, callback?: () => void): void; @@ -20,15 +20,15 @@ export default class Siema { destroy(restoreMarkup?: boolean, callback?: () => void): void; } -export interface IPageInterface { +export interface PageInterface { [key: number]: number; } -export interface ISiemaOptions { +export interface SiemaOptions { selector?: string | HTMLElement; duration?: number; easing?: string; - perPage?: number | IPageInterface; + perPage?: number | PageInterface; startIndex?: number; draggable?: boolean; multipleDrag?: boolean;