From 18d3e314ea092b6fabf6225b8a69e40e3aba8b77 Mon Sep 17 00:00:00 2001 From: Zain Afzal Date: Wed, 23 Jan 2019 15:41:39 +1100 Subject: [PATCH 1/3] Fixed Label Rendering callback in react-json-tree --- types/react-json-tree/index.d.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index d0ab7cab62..600de66fb8 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -1,6 +1,7 @@ -// Type definitions for react-json-tree v0.6.5 +// Type definitions for react-json-tree v0.6.6 // Project: https://github.com/alexkuz/react-json-tree/ // Definitions by: Grant Nestor +// Zain Afzal // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 @@ -18,7 +19,7 @@ export interface JSONTreeProps extends Props { sortObjectKeys?: Function | boolean; shouldExpandNode?: (keyPath: (string | number)[], data: [any] | {}, level: number) => boolean; getItemString?: (type: string, data: [any] | {}, itemType: string, itemString: string) => JSX.Element; - labelRenderer?: (raw: [string, string]) => JSX.Element; + labelRenderer?: (keyPath: string[], nodeType: string, expanded: boolean, expandable: boolean) => JSX.Element; valueRenderer?: (displayValue: string|number, rawValue?: string|number|boolean|null, ...keyPath: (string|number)[]) => JSX.Element; postprocessValue?: (raw: string) => JSX.Element; isCustomNode?: () => boolean; From d74ed1acba85573440e78cff4a57c8c7386cc4e0 Mon Sep 17 00:00:00 2001 From: Zain Afzal Date: Wed, 23 Jan 2019 15:48:34 +1100 Subject: [PATCH 2/3] Make paramaters after keyPath optional --- types/react-json-tree/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index 600de66fb8..6fc37c4941 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -19,7 +19,7 @@ export interface JSONTreeProps extends Props { sortObjectKeys?: Function | boolean; shouldExpandNode?: (keyPath: (string | number)[], data: [any] | {}, level: number) => boolean; getItemString?: (type: string, data: [any] | {}, itemType: string, itemString: string) => JSX.Element; - labelRenderer?: (keyPath: string[], nodeType: string, expanded: boolean, expandable: boolean) => JSX.Element; + labelRenderer?: (keyPath: string[], nodeType?: string, expanded?: boolean, expandable?: boolean) => JSX.Element; valueRenderer?: (displayValue: string|number, rawValue?: string|number|boolean|null, ...keyPath: (string|number)[]) => JSX.Element; postprocessValue?: (raw: string) => JSX.Element; isCustomNode?: () => boolean; From 409fc7fb164367a80c75efa02c97877c9511bf22 Mon Sep 17 00:00:00 2001 From: Zain Afzal Date: Tue, 29 Jan 2019 07:54:29 +1100 Subject: [PATCH 3/3] Fixed header --- types/react-json-tree/index.d.ts | 2 +- types/react-json-tree/tslint.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/types/react-json-tree/index.d.ts b/types/react-json-tree/index.d.ts index 6fc37c4941..c57cdd3d51 100644 --- a/types/react-json-tree/index.d.ts +++ b/types/react-json-tree/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for react-json-tree v0.6.6 +// Type definitions for react-json-tree 0.6 // Project: https://github.com/alexkuz/react-json-tree/ // Definitions by: Grant Nestor // Zain Afzal diff --git a/types/react-json-tree/tslint.json b/types/react-json-tree/tslint.json index e3610fefae..92d14c6344 100644 --- a/types/react-json-tree/tslint.json +++ b/types/react-json-tree/tslint.json @@ -7,7 +7,6 @@ "ban-types": false, "callable-types": false, "comment-format": false, - "dt-header": false, "eofline": false, "export-just-namespace": false, "import-spacing": false,