From f0bedc9acb099a2dff39147b871fbfe67600a23b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Cunico?= <60931026+cunicocwb@users.noreply.github.com> Date: Tue, 25 Feb 2020 17:22:03 -0300 Subject: [PATCH] [@types/sdp-transform] fix incorrect types (#42278) (#42606) MediaAttributes.rtcpFb and MediaAttributes.rtcpFbTrrInt were changed to arrays. --- types/sdp-transform/index.d.ts | 8 ++++---- types/sdp-transform/sdp-transform-tests.ts | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/types/sdp-transform/index.d.ts b/types/sdp-transform/index.d.ts index 8b10216a67..ae347e9cca 100644 --- a/types/sdp-transform/index.d.ts +++ b/types/sdp-transform/index.d.ts @@ -147,16 +147,16 @@ export interface MediaAttributes extends SharedAttributes { address?: string; }; // a=rtcp-fb:98 nack rpsi - rtcpFb?: { + rtcpFb?: Array<{ payload: number; type: string; subtype?: string; - }; + }>; // a=rtcp-fb:98 trr-int 100 - rtcpFbTrrInt?: { + rtcpFbTrrInt?: Array<{ payload: number; value: number; - }; + }>; // a=fmtp fmtp: Array<{ payload: number; diff --git a/types/sdp-transform/sdp-transform-tests.ts b/types/sdp-transform/sdp-transform-tests.ts index fce4ecc26d..53e9b3e541 100644 --- a/types/sdp-transform/sdp-transform-tests.ts +++ b/types/sdp-transform/sdp-transform-tests.ts @@ -13,4 +13,6 @@ const codec: string = session.media[0].rtp[0].codec; session.media[0].rtp[0].codec = 'opus'; const config: string = session.media[0].fmtp[0].config; session.media[0].fmtp[0].config = 'maxplaybackrate=48000;stereo=1;useinbandfec=1'; +session.media[0].rtcpFb = [{ payload: 96, type: 'ccm', subtype: 'fir' }, { payload: 98, type: 'nack', subtype: 'rpsi' }]; +session.media[0].rtcpFbTrrInt = [{ payload: 96, value: 100 }, { payload: 98, value: 100 }]; const sdp: string = write(session);