From 6396ec36c8e66976e1d70e8ee9971fb28f1b358e Mon Sep 17 00:00:00 2001 From: MaxKornilov <44263165+MaxKornilov@users.noreply.github.com> Date: Thu, 18 Oct 2018 15:37:04 +0300 Subject: [PATCH 1/2] Select method moved to FrameBase --- types/puppeteer/index.d.ts | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/types/puppeteer/index.d.ts b/types/puppeteer/index.d.ts index 3ff4efbe4b..0e7f415edc 100644 --- a/types/puppeteer/index.d.ts +++ b/types/puppeteer/index.d.ts @@ -1168,6 +1168,15 @@ export interface FrameBase extends Evalable { * @param selector A selector to search for element to hover. If there are multiple elements satisfying the selector, the first will be hovered. */ hover(selector: string): Promise; + + /** + * Triggers a `change` and `input` event once all the provided options have been selected. + * If there's no `` has the `multiple` attribute, + * all values are considered, otherwise only the first one is taken into account. + */ + select(selector: string, ...values: string[]): Promise; /** * Sets the page content. @@ -1472,15 +1481,6 @@ export interface Page extends EventEmitter, FrameBase { screenshot(options?: BinaryScreenShotOptions): Promise; screenshot(options?: ScreenshotOptions): Promise; - /** - * Triggers a `change` and `input` event once all the provided options have been selected. - * If there's no `` has the `multiple` attribute, - * all values are considered, otherwise only the first one is taken into account. - */ - select(selector: string, ...values: string[]): Promise; - /** * Toggles bypassing page's Content-Security-Policy. * NOTE CSP bypassing happens at the moment of CSP initialization rather then evaluation. From b3f7b57c94d1a0c5496be9edbe65760bf4a9a250 Mon Sep 17 00:00:00 2001 From: MaxKornilov <44263165+MaxKornilov@users.noreply.github.com> Date: Thu, 18 Oct 2018 16:08:33 +0300 Subject: [PATCH 2/2] trailing whitespace removed --- types/puppeteer/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/puppeteer/index.d.ts b/types/puppeteer/index.d.ts index 0e7f415edc..f1669473a6 100644 --- a/types/puppeteer/index.d.ts +++ b/types/puppeteer/index.d.ts @@ -1168,7 +1168,7 @@ export interface FrameBase extends Evalable { * @param selector A selector to search for element to hover. If there are multiple elements satisfying the selector, the first will be hovered. */ hover(selector: string): Promise; - + /** * Triggers a `change` and `input` event once all the provided options have been selected. * If there's no `