From 77159b4b96175b2ecfabed28d35ffed83017db8c Mon Sep 17 00:00:00 2001 From: Beeno Tung Date: Sat, 18 Aug 2018 17:39:35 +0800 Subject: [PATCH 1/5] added ed25519 in pki --- types/node-forge/index.d.ts | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/types/node-forge/index.d.ts b/types/node-forge/index.d.ts index 65ff4edb47..41c573d5b8 100644 --- a/types/node-forge/index.d.ts +++ b/types/node-forge/index.d.ts @@ -73,6 +73,33 @@ declare module "node-forge" { function generateKeyPair(options?: GenerateKeyPairOptions, callback?: (err: Error, keypair: KeyPair) => void): KeyPair; } + namespace ed25519 { + + type NativeBuffer = Buffer | Uint8Array; + + namespace constants { + const PUBLIC_KEY_BYTE_LENGTH = 32; + const PRIVATE_KEY_BYTE_LENGTH = 64; + const SEED_BYTE_LENGTH = 32; + const SIGN_BYTE_LENGTH = 64; + const HASH_BYTE_LENGTH = 64; + } + + function generateKeyPair(options?: { seed?: Buffer | Uint8Array | string }): { + publicKey: NativeBuffer; + privateKey: NativeBuffer; + }; + + function publicKeyFromPrivateKey(options: { privateKey: NativeBuffer }): NativeBuffer; + + function sign(options: { privateKey: NativeBuffer }): NativeBuffer; + + function verify(options: { + signature: Buffer | Uint8Array | util.ByteBuffer | string, + publicKey: NativeBuffer + }): boolean; + } + interface CertificateFieldOptions { name?: string; type?: string; From a46775def5d3415e35e9f4c35df081bd9e6c27a0 Mon Sep 17 00:00:00 2001 From: Beeno Tung Date: Sat, 25 Aug 2018 00:07:06 +0800 Subject: [PATCH 2/5] adding dependency of @types/node to @types/node-forge --- types/node-forge/README.md | 29 +++++++++++++++++++++++++++++ types/node-forge/index.d.ts | 3 ++- types/urllib/README.md | 6 +++--- 3 files changed, 34 insertions(+), 4 deletions(-) create mode 100644 types/node-forge/README.md diff --git a/types/node-forge/README.md b/types/node-forge/README.md new file mode 100644 index 0000000000..fcac651de8 --- /dev/null +++ b/types/node-forge/README.md @@ -0,0 +1,29 @@ +# DefinitelyTyped for node-forge + +## Current node-forge Version +`v0.7.6` +## Usage + +```bash +npm install --save-dev @types/node-forge +npm install --save node-forge +``` + +example: +```ts +import * as forge from "node-forge"; + +Buffer.isBuffer(forge.pki.ed25519.generateKeyPair().publicKey) // true +``` +## License +BSD-2-Clause + +## dependencies +`@types/node` + +## Author +[Seth Westphal](https://github.com/westy92) +[Kay Schecker](https://github.com/flynetworks) +[Aakash Goenka](https://github.com/a-k-g) +[Rafal2228](https://github.com/rafal2228) +[Beeno Tung](https://github.com/beenotung) diff --git a/types/node-forge/index.d.ts b/types/node-forge/index.d.ts index 41c573d5b8..cc61e999da 100644 --- a/types/node-forge/index.d.ts +++ b/types/node-forge/index.d.ts @@ -1,9 +1,10 @@ -// Type definitions for node-forge 0.7.5 +// Type definitions for node-forge 0.7.6 // Project: https://github.com/digitalbazaar/forge // Definitions by: Seth Westphal // Kay Schecker // Aakash Goenka // Rafal2228 +// Beeno Tung // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped declare module "node-forge" { diff --git a/types/urllib/README.md b/types/urllib/README.md index 36acda5c50..8bfc215185 100644 --- a/types/urllib/README.md +++ b/types/urllib/README.md @@ -1,16 +1,16 @@ # DefinitelyTyped for Urllib ## Current Urllib Version -`v2.25.4` +`v0.7.6` ## Usage ```bash -npm install --save-dev @types/urllib +npm install --save-dev @types/node-forge ``` example: ```ts -import * as urllib from "."; +import * as forge from "."; urllib.curl('https://example.test.com', { method: "GET", From 62f18451507a5211c2d35333c80cd1d3b27dada1 Mon Sep 17 00:00:00 2001 From: Beeno Tung Date: Sat, 25 Aug 2018 00:16:38 +0800 Subject: [PATCH 3/5] restored readme in urllib changed in accident in last commit --- types/urllib/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/types/urllib/README.md b/types/urllib/README.md index 8bfc215185..36acda5c50 100644 --- a/types/urllib/README.md +++ b/types/urllib/README.md @@ -1,16 +1,16 @@ # DefinitelyTyped for Urllib ## Current Urllib Version -`v0.7.6` +`v2.25.4` ## Usage ```bash -npm install --save-dev @types/node-forge +npm install --save-dev @types/urllib ``` example: ```ts -import * as forge from "."; +import * as urllib from "."; urllib.curl('https://example.test.com', { method: "GET", From 0959c07fb0c146b89c859fc76068f5932aa815dd Mon Sep 17 00:00:00 2001 From: Beeno Tung Date: Sat, 25 Aug 2018 00:30:23 +0800 Subject: [PATCH 4/5] added type ref on node in node-forge --- types/node-forge/index.d.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/types/node-forge/index.d.ts b/types/node-forge/index.d.ts index cc61e999da..0e1a1a007d 100644 --- a/types/node-forge/index.d.ts +++ b/types/node-forge/index.d.ts @@ -7,6 +7,8 @@ // Beeno Tung // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +/// + declare module "node-forge" { type Byte = string; type Bytes = string; From e518cc519edd35e3262ff1be4ea61da4c7e669ba Mon Sep 17 00:00:00 2001 From: Beeno Tung Date: Sat, 25 Aug 2018 01:06:39 +0800 Subject: [PATCH 5/5] fixing test error in node-forge --- types/node-forge/index.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/types/node-forge/index.d.ts b/types/node-forge/index.d.ts index 0e1a1a007d..e30a217ddc 100644 --- a/types/node-forge/index.d.ts +++ b/types/node-forge/index.d.ts @@ -6,6 +6,7 @@ // Rafal2228 // Beeno Tung // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped +// TypeScript Version: 2.6 ///