From f2fd8100a8380fd7c202c215b15c5da1e338cc86 Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Tue, 22 Sep 2015 10:47:33 +0200 Subject: [PATCH] made sure tests / typings succeed on typescript 1.6.2 --- mobservable-react/mobservable-react-tests.ts | 5 ++++- mobservable-react/mobservable-react.d.ts | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/mobservable-react/mobservable-react-tests.ts b/mobservable-react/mobservable-react-tests.ts index 7bda00cf43..7b39dbb7fb 100644 --- a/mobservable-react/mobservable-react-tests.ts +++ b/mobservable-react/mobservable-react-tests.ts @@ -51,7 +51,10 @@ class TestComponent2 extends React.Component<{ test: string },{}> { } } { - let c4Factory = React.createFactory(reactiveComponent(TestComponent2)); + // Does not work properly in typescript 1.6.2 without cast :'( + // Argument of type 'typeof TestComponent2 | void' is not assignable to parameter of type 'ComponentClass<{ test: string; }>'. + // Type 'void' is not assignable to type 'ComponentClass<{ test: string; }>'. + let c4Factory = React.createFactory(> reactiveComponent(TestComponent2)); React.render(c4Factory({ test: "hello" }) , null); diff --git a/mobservable-react/mobservable-react.d.ts b/mobservable-react/mobservable-react.d.ts index 34ecd78f8e..f42627a857 100644 --- a/mobservable-react/mobservable-react.d.ts +++ b/mobservable-react/mobservable-react.d.ts @@ -11,6 +11,6 @@ declare module "mobservable-react" { */ export function reactiveComponent

(clazz: React.ClassicComponentClass

): React.ClassicComponentClass

; export function reactiveComponent

(clazz: React.ComponentClass

): React.ComponentClass

; - export function reactiveComponent

(clazz: React.ComponentClass

): void; // for decorator + export function reactiveComponent>(target: TFunction): TFunction | void; // decorator signature export function reactiveComponent

(renderFunction: (props: P) => React.ReactElement): React.ClassicComponentClass

; } \ No newline at end of file