From f5e307c0da86f416092f8c97c25bfffb1ace2b91 Mon Sep 17 00:00:00 2001 From: Corbin Crutchley Date: Tue, 25 Feb 2020 16:29:13 -0800 Subject: [PATCH] [react-aria-modal] Added missing conditional for underlayColor (#42356) --- types/react-aria-modal/index.d.ts | 3 ++- types/react-aria-modal/react-aria-modal-tests.tsx | 15 +++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/types/react-aria-modal/index.d.ts b/types/react-aria-modal/index.d.ts index 292d0b50dd..19e78cb3db 100644 --- a/types/react-aria-modal/index.d.ts +++ b/types/react-aria-modal/index.d.ts @@ -3,6 +3,7 @@ // Definitions by: gabycperezdias // forabi // dkrk +// Corbin Crutchley // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 @@ -142,7 +143,7 @@ export interface AriaModalProps { * * Default: rgba(0,0,0,0.5) */ - underlayColor?: string; + underlayColor?: string | false; /** * If `true`, the modal's contents will be vertically (as well as horizontally) centered. diff --git a/types/react-aria-modal/react-aria-modal-tests.tsx b/types/react-aria-modal/react-aria-modal-tests.tsx index 58b61849ca..55a33a1560 100644 --- a/types/react-aria-modal/react-aria-modal-tests.tsx +++ b/types/react-aria-modal/react-aria-modal-tests.tsx @@ -21,3 +21,18 @@ render( , appContainer ); + +render( + {}} + alert={true} + focusDialog={true} + titleText='A top modal' + underlayClickExits={false} + verticallyCenter={true} + underlayColor={false} + > +
Hello
+
, + appContainer +);