From 9bdb3afa3b64d219800dce567fc700a3b4fe5c98 Mon Sep 17 00:00:00 2001 From: zwh8800 Date: Sat, 25 Nov 2017 15:39:28 +0800 Subject: [PATCH 1/2] fix @types/puppeteer $eval type error --- types/puppeteer/index.d.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/types/puppeteer/index.d.ts b/types/puppeteer/index.d.ts index b6220485fb..b1f214aa7b 100644 --- a/types/puppeteer/index.d.ts +++ b/types/puppeteer/index.d.ts @@ -667,7 +667,8 @@ export interface FrameBase { */ $eval( selector: string, - fn: (...args: any[]) => void + fn: (ele: ElementHandle | null, ...args: any[]) => any, + ...args: any[] ): Promise; /** @@ -680,7 +681,7 @@ export interface FrameBase { */ $$eval( selector: string, - fn: (...args: any[]) => void, + fn: (eles: ElementHandle[], ...args: any[]) => any, ...args: any[] ): Promise; From aa7f42d55d629b5ff14de02a4c2d61cb220e852c Mon Sep 17 00:00:00 2001 From: zwh8800 Date: Sat, 25 Nov 2017 22:43:01 +0800 Subject: [PATCH 2/2] rename ele to element --- types/puppeteer/index.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/types/puppeteer/index.d.ts b/types/puppeteer/index.d.ts index b1f214aa7b..311d2c47b7 100644 --- a/types/puppeteer/index.d.ts +++ b/types/puppeteer/index.d.ts @@ -667,7 +667,7 @@ export interface FrameBase { */ $eval( selector: string, - fn: (ele: ElementHandle | null, ...args: any[]) => any, + fn: (element: ElementHandle | null, ...args: any[]) => any, ...args: any[] ): Promise; @@ -681,7 +681,7 @@ export interface FrameBase { */ $$eval( selector: string, - fn: (eles: ElementHandle[], ...args: any[]) => any, + fn: (elements: ElementHandle[], ...args: any[]) => any, ...args: any[] ): Promise;