From 842e595c53447ccf07a965a95e43377f6f8c7ca8 Mon Sep 17 00:00:00 2001 From: Renzo Slijp Date: Thu, 3 Jul 2014 11:34:14 +0200 Subject: [PATCH 1/2] Changed generic type of IHttpPromiseCallback for error callback to allow for difrent return type. It's likely that the error return type is different from the regular result type --- angularjs/angular.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/angularjs/angular.d.ts b/angularjs/angular.d.ts index e2de2a0b05..368e638e35 100755 --- a/angularjs/angular.d.ts +++ b/angularjs/angular.d.ts @@ -820,7 +820,7 @@ declare module ng { interface IHttpPromise extends IPromise { success(callback: IHttpPromiseCallback): IHttpPromise; - error(callback: IHttpPromiseCallback): IHttpPromise; + error(callback: IHttpPromiseCallback): IHttpPromise; then(successCallback: (response: IHttpPromiseCallbackArg) => IPromise, errorCallback?: (response: IHttpPromiseCallbackArg) => any): IPromise; then(successCallback: (response: IHttpPromiseCallbackArg) => TResult, errorCallback?: (response: IHttpPromiseCallbackArg) => any): IPromise; } From 4e1c39e76e7dd1ae3eef1b07163eac0e88be7d0c Mon Sep 17 00:00:00 2001 From: Renzo Slijp Date: Thu, 3 Jul 2014 15:47:51 +0200 Subject: [PATCH 2/2] Changed generic type of IHttpPromiseCallback for error callback in then chaining --- angularjs/angular.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/angularjs/angular.d.ts b/angularjs/angular.d.ts index 368e638e35..11763d6083 100755 --- a/angularjs/angular.d.ts +++ b/angularjs/angular.d.ts @@ -821,8 +821,8 @@ declare module ng { interface IHttpPromise extends IPromise { success(callback: IHttpPromiseCallback): IHttpPromise; error(callback: IHttpPromiseCallback): IHttpPromise; - then(successCallback: (response: IHttpPromiseCallbackArg) => IPromise, errorCallback?: (response: IHttpPromiseCallbackArg) => any): IPromise; - then(successCallback: (response: IHttpPromiseCallbackArg) => TResult, errorCallback?: (response: IHttpPromiseCallbackArg) => any): IPromise; + then(successCallback: (response: IHttpPromiseCallbackArg) => IPromise, errorCallback?: (response: IHttpPromiseCallbackArg) => any): IPromise; + then(successCallback: (response: IHttpPromiseCallbackArg) => TResult, errorCallback?: (response: IHttpPromiseCallbackArg) => any): IPromise; } interface IHttpProvider extends IServiceProvider {