From f9fb7e64a56af01b4f80c97eb5064a28cb7f59be Mon Sep 17 00:00:00 2001
From: Lucas Garron <lgarron@github.com>
Date: Wed, 17 Jul 2019 14:32:24 -0700
Subject: [PATCH] [@types/webappsec-credential-management] Add optional icon to
 `PublicKeyCredentialEntity`. (#36812)

* [webappsec-credential-management] Add optional icon to `PublicKeyCredentialEntity`.

This also factors out `PublicKeyCredentialEntity` from the RP/user
definitions, like the spec does.

* Swap order to match `dom.generated.d.ts`.
---
 types/webappsec-credential-management/index.d.ts | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/types/webappsec-credential-management/index.d.ts b/types/webappsec-credential-management/index.d.ts
index 1af82962dd..13e33c59c2 100644
--- a/types/webappsec-credential-management/index.d.ts
+++ b/types/webappsec-credential-management/index.d.ts
@@ -401,20 +401,26 @@ interface PublicKeyCredentialRequestOptions {
     extensions?: AuthenticationExtensionsClientInputs;
 }
 
+/**
+ * @see {@link https://w3c.github.io/webauthn/#dictdef-publickeycredentialentity}
+ */
+interface PublicKeyCredentialEntity {
+    icon?: string;
+    name: string;
+}
+
 /**
  * @see {@link https://w3c.github.io/webauthn/#dictdef-publickeycredentialrpentity}
  */
-interface PublicKeyCredentialRpEntity {
+interface PublicKeyCredentialRpEntity extends PublicKeyCredentialEntity {
     id?: string;
-    name: string;
 }
 
 /**
  * @see {@link https://w3c.github.io/webauthn/#dictdef-publickeycredentialuserentity}
  */
-interface PublicKeyCredentialUserEntity {
+interface PublicKeyCredentialUserEntity extends PublicKeyCredentialEntity {
     id: BufferSource;
-    name: string;
     displayName: string;
 }