From fb6990cd4d6d4e0159bf27bd136833bbcc50aa71 Mon Sep 17 00:00:00 2001 From: kenjiru Date: Thu, 12 Jul 2018 18:54:00 +0200 Subject: [PATCH] [backbone] Update the options for Collection.fetch (#27123) --- types/backbone/backbone-tests.ts | 5 ++++- types/backbone/index.d.ts | 6 ++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/types/backbone/backbone-tests.ts b/types/backbone/backbone-tests.ts index 7b6fad9b56..65a1463978 100644 --- a/types/backbone/backbone-tests.ts +++ b/types/backbone/backbone-tests.ts @@ -398,7 +398,10 @@ namespace v1Changes { namespace Collection { function test_fetch() { var collection = new EmployeeCollection; - collection.fetch({ reset: true }); + collection.fetch({ + reset: true, + remove: false + }); } function test_create() { diff --git a/types/backbone/index.d.ts b/types/backbone/index.d.ts index 3d4c90d369..81bce43606 100644 --- a/types/backbone/index.d.ts +++ b/types/backbone/index.d.ts @@ -1,6 +1,8 @@ // Type definitions for Backbone 1.3.3 // Project: http://backbonejs.org/ -// Definitions by: Boris Yankov , Natan Vivo +// Definitions by: Boris Yankov +// Natan Vivo +// kenjiru // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 @@ -76,7 +78,7 @@ declare namespace Backbone { interface ModelDestroyOptions extends Waitable, PersistenceOptions { } - interface CollectionFetchOptions extends PersistenceOptions, Parseable { + interface CollectionFetchOptions extends PersistenceOptions, Parseable, CollectionSetOptions { reset?: boolean; }