From e4eeaf874062b5b13b6dab14d79a2c760b364c73 Mon Sep 17 00:00:00 2001 From: Laurens Rietveld Date: Wed, 31 Oct 2018 15:15:48 +0100 Subject: [PATCH 1/2] Use single generic for I/O types of datafactory functions --- types/rdf-js/index.d.ts | 4 ++-- types/rdf-js/rdf-js-tests.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/types/rdf-js/index.d.ts b/types/rdf-js/index.d.ts index 41491d8d09..964f042134 100644 --- a/types/rdf-js/index.d.ts +++ b/types/rdf-js/index.d.ts @@ -297,7 +297,7 @@ export interface DataFactory { * @see Triple * @see DefaultGraph */ - triple(subject: Q_In['subject'], predicate: Q_In['predicate'], object: Q_In['object']): Q_Out; + triple(subject: Q['subject'], predicate: Q['predicate'], object: Q['object']): Q; /** * @param subject The quad subject term. @@ -307,7 +307,7 @@ export interface DataFactory { * @return A new instance of Quad. * @see Quad */ - quad(subject: Q_In['subject'], predicate: Q_In['predicate'], object: Q_In['object'], graph?: Q_In['graph']): Q_Out; + quad(subject: Q['subject'], predicate: Q['predicate'], object: Q['object'], graph?: Q['graph']): Q; } /* Stream Interfaces */ diff --git a/types/rdf-js/rdf-js-tests.ts b/types/rdf-js/rdf-js-tests.ts index eb55002149..12b92b952d 100644 --- a/types/rdf-js/rdf-js-tests.ts +++ b/types/rdf-js/rdf-js-tests.ts @@ -77,7 +77,7 @@ function test_datafactory() { object: Term; graph: Term; } - const quad = dataFactory.quad(literal1, blankNode1, term, term); + const quad = dataFactory.quad(literal1, blankNode1, term, term); const hasBnode = quad.predicate.termType === "BlankNode"; } From 7235611c65bdc5bc9cf6e24d3e6bf6d03d4b9a4b Mon Sep 17 00:00:00 2001 From: Laurens Rietveld Date: Tue, 6 Nov 2018 11:33:06 +0100 Subject: [PATCH 2/2] Removed unnecessary linting Constraint --- types/rdf-js/tslint.json | 1 - 1 file changed, 1 deletion(-) diff --git a/types/rdf-js/tslint.json b/types/rdf-js/tslint.json index e27ad90359..724f3870ca 100644 --- a/types/rdf-js/tslint.json +++ b/types/rdf-js/tslint.json @@ -1,6 +1,5 @@ { "extends": "dtslint/dt.json", "rules": { - "no-unnecessary-generics": false } }