From 7ba12568d90346a9caa2464e5b3f1320f514308b Mon Sep 17 00:00:00 2001 From: Elias Chaaya Date: Fri, 11 Jan 2019 13:41:02 +0100 Subject: [PATCH 1/3] Fix updated definitions to match the latest release --- types/react-image-crop/index.d.ts | 8 ++++++-- .../test/react-image-crop-global-tests.ts | 7 +++++++ .../test/react-image-crop-module-tests.tsx | 7 +++++++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/types/react-image-crop/index.d.ts b/types/react-image-crop/index.d.ts index 7f3637d093..403af177c6 100644 --- a/types/react-image-crop/index.d.ts +++ b/types/react-image-crop/index.d.ts @@ -1,6 +1,7 @@ -// Type definitions for react-image-crop 3.0 +// Type definitions for react-image-crop 6.0 // Project: https://github.com/DominicTobias/react-image-crop // Definitions by: Daniela Yassuda +// Elias Chaaya // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.8 @@ -39,10 +40,13 @@ declare namespace ReactCrop { onDragStart?: () => void; onDragEnd?: () => void; disabled?: boolean; - crossorigin?: string; + crossorigin?: "anonymous" | 'use-credentials'; children?: ReactNode; style?: CSSProperties; imageStyle?: CSSProperties; + onImageError?: (event: React.SyntheticEvent) => void; + className?: string; + locked?: boolean; } function getPixelCrop(image: HTMLImageElement, percentCrop: Crop): Crop; diff --git a/types/react-image-crop/test/react-image-crop-global-tests.ts b/types/react-image-crop/test/react-image-crop-global-tests.ts index 1ba4759420..cec99abf95 100644 --- a/types/react-image-crop/test/react-image-crop-global-tests.ts +++ b/types/react-image-crop/test/react-image-crop-global-tests.ts @@ -85,6 +85,10 @@ class CompleteTest extends React.Component<{}, TestState> { }); } + onImageError = (event: React.SyntheticEvent) => { + console.warn('Error loading image'); + } + render() { return React.createElement( ReactCrop, @@ -104,6 +108,9 @@ class CompleteTest extends React.Component<{}, TestState> { onDragStart: () => console.log('Drag start'), onDragEnd: () => console.log('Drag end'), crossorigin: 'anonymous', + onImageError: this.onImageError, + className: 'my-cropper', + locked: false }, ); } diff --git a/types/react-image-crop/test/react-image-crop-module-tests.tsx b/types/react-image-crop/test/react-image-crop-module-tests.tsx index 7bd696bf32..a92371dc8a 100644 --- a/types/react-image-crop/test/react-image-crop-module-tests.tsx +++ b/types/react-image-crop/test/react-image-crop-module-tests.tsx @@ -81,6 +81,10 @@ class CompleteTest extends React.Component<{}, TestState> { }); } + onImageError = (event: React.SyntheticEvent) => { + console.warn('Error loading image'); + } + render() { return ( { onDragStart={() => console.log('Drag start')} onDragEnd={() => console.log('Drag end')} crossorigin="anonymous" + onImageError={this.onImageError} + className="my-cropper" + locked={false} /> ); } From eece05af3ff9dd2e70ae5f2ab797ccef2338c558 Mon Sep 17 00:00:00 2001 From: Daniel Rosenwasser Date: Wed, 16 Jan 2019 10:57:22 -0800 Subject: [PATCH 2/3] Update index.d.ts --- types/react-image-crop/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-image-crop/index.d.ts b/types/react-image-crop/index.d.ts index 403af177c6..5589261452 100644 --- a/types/react-image-crop/index.d.ts +++ b/types/react-image-crop/index.d.ts @@ -40,7 +40,7 @@ declare namespace ReactCrop { onDragStart?: () => void; onDragEnd?: () => void; disabled?: boolean; - crossorigin?: "anonymous" | 'use-credentials'; + crossorigin?: 'anonymous' | 'use-credentials'; children?: ReactNode; style?: CSSProperties; imageStyle?: CSSProperties; From 64f80aee7cc8594a22cfc717eb51425700dd4a85 Mon Sep 17 00:00:00 2001 From: Elias Chaaya Date: Thu, 17 Jan 2019 16:08:52 +0100 Subject: [PATCH 3/3] fix: updated signature of onImageLoaded --- types/react-image-crop/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/react-image-crop/index.d.ts b/types/react-image-crop/index.d.ts index 403af177c6..0d9f018ed5 100644 --- a/types/react-image-crop/index.d.ts +++ b/types/react-image-crop/index.d.ts @@ -36,7 +36,7 @@ declare namespace ReactCrop { keepSelection?: boolean; onChange: (crop: Crop, pixelCrop: PixelCrop) => void; onComplete?: (crop: Crop, pixelCrop: PixelCrop) => void; - onImageLoaded?: (target: HTMLImageElement) => void; + onImageLoaded?: (target: HTMLImageElement, pixelCrop: PixelCrop) => void; onDragStart?: () => void; onDragEnd?: () => void; disabled?: boolean;