From 597795c538993b7590630ca96a1ef6cf27021a62 Mon Sep 17 00:00:00 2001 From: Panu Horsmalahti Date: Wed, 4 Feb 2015 15:30:53 +0200 Subject: [PATCH 1/2] Add ZeroMQ unbind function types --- node_zeromq/zmq-tests.ts | 4 ++++ node_zeromq/zmq.d.ts | 17 +++++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/node_zeromq/zmq-tests.ts b/node_zeromq/zmq-tests.ts index 6481932598..696a98c13b 100644 --- a/node_zeromq/zmq-tests.ts +++ b/node_zeromq/zmq-tests.ts @@ -5,6 +5,7 @@ import zmq = require('zmq'); function test1() { var sock = zmq.socket('push'); sock.bindSync('tcp://127.0.0.1:3000'); + sock.unbindSync('tcp://127.0.0.1:3000'); sock.send("some work"); } @@ -28,6 +29,9 @@ function test4() { sock.bind('tcp://127.0.0.1', err => { sock.send("some work"); }); + sock.unbind('tcp://127.0.0.1', err => { + // + }); } function test5() { diff --git a/node_zeromq/zmq.d.ts b/node_zeromq/zmq.d.ts index e84615c858..7314612043 100644 --- a/node_zeromq/zmq.d.ts +++ b/node_zeromq/zmq.d.ts @@ -94,6 +94,23 @@ declare module 'zmq' { */ bindSync(addr: string): Socket; + /** + * Async unbind. + * + * Emits the "unbind" event. + * + * @param addr Socket address + * @param cb Unind callback + */ + unbind(addr: string, callback: (error: string) => void ): Socket; + + /** + * Sync unbind. + * + * @param addr Socket address + */ + unbindSync(addr: string): Socket; + /** * Connect to `addr`. * From d10a94e0e1633361eebab6749dcf5085c82d451a Mon Sep 17 00:00:00 2001 From: Panu Horsmalahti Date: Wed, 4 Feb 2015 18:15:22 +0200 Subject: [PATCH 2/2] Update zmq.d.ts Made callbacks optional --- node_zeromq/zmq.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/node_zeromq/zmq.d.ts b/node_zeromq/zmq.d.ts index 7314612043..8d29e05691 100644 --- a/node_zeromq/zmq.d.ts +++ b/node_zeromq/zmq.d.ts @@ -85,7 +85,7 @@ declare module 'zmq' { * @param addr Socket address * @param cb Bind callback */ - bind(addr: string, callback: (error: string) => void ): Socket; + bind(addr: string, callback?: (error: string) => void ): Socket; /** * Sync bind. @@ -102,7 +102,7 @@ declare module 'zmq' { * @param addr Socket address * @param cb Unind callback */ - unbind(addr: string, callback: (error: string) => void ): Socket; + unbind(addr: string, callback?: (error: string) => void ): Socket; /** * Sync unbind.