From d3c9c35fc625641c4c95d54eef25a8c0d84e71a7 Mon Sep 17 00:00:00 2001
From: Mihkel Sokk <mihkelsokk@gmail.com>
Date: Mon, 26 Nov 2018 14:26:50 +0200
Subject: [PATCH] [ejs] renderFile returns Promise without callback, fixes
 #28934

---
 types/ejs/ejs-tests.ts | 3 +++
 types/ejs/index.d.ts   | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/types/ejs/ejs-tests.ts b/types/ejs/ejs-tests.ts
index 8a0b2404d7..881a3fe103 100644
--- a/types/ejs/ejs-tests.ts
+++ b/types/ejs/ejs-tests.ts
@@ -29,6 +29,9 @@ result = ejs.render(template, data, options);
 result = ejs.renderFile(fileName, SimpleCallback);
 result = ejs.renderFile(fileName, data, SimpleCallback);
 result = ejs.renderFile(fileName, data, options, SimpleCallback);
+asyncResult = ejs.renderFile(fileName);
+asyncResult = ejs.renderFile(fileName, data);
+asyncResult = ejs.renderFile(fileName, data, options);
 
 ejsFunction = ejs.compile('');
 ejsFunction = ejs.compile(read(fileName, "utf8"));
diff --git a/types/ejs/index.d.ts b/types/ejs/index.d.ts
index 73eb716e23..fc578cffff 100644
--- a/types/ejs/index.d.ts
+++ b/types/ejs/index.d.ts
@@ -54,6 +54,8 @@ export type RenderFileCallback<T> = (err: Error, str?: string) => T;
 export function renderFile<T>(path: string, cb: RenderFileCallback<T>): T;
 export function renderFile<T>(path: string, data: Data, cb: RenderFileCallback<T>): T;
 export function renderFile<T>(path: string, data: Data, opts: Options, cb: RenderFileCallback<T>): T;
+// tslint:disable-next-line no-unnecessary-generics
+export function renderFile<T>(path: string, data?: Data, opts?: Options): Promise<T>;
 
 /**
  * Clear intermediate JavaScript cache. Calls {@link Cache#reset}.