From 40a557091da9e371df263351a3a9f214b40956e5 Mon Sep 17 00:00:00 2001 From: Matt Lewis Date: Mon, 18 Dec 2017 10:12:16 +0000 Subject: [PATCH 1/5] twitter-text: update for v2 --- types/twitter-text/index.d.ts | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/types/twitter-text/index.d.ts b/types/twitter-text/index.d.ts index e12cfc59a9..def33e238d 100644 --- a/types/twitter-text/index.d.ts +++ b/types/twitter-text/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for twitter-text v1.13.4 +// Type definitions for twitter-text v2.0.0 // Project: https://github.com/twitter/twitter-text // Definitions by: rhysd // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -101,3 +101,15 @@ export declare function getUnicodeTextLength(text: string): number; export declare function convertUnicodeIndices(text: string, entities: EntityWithIndices[], indicesInUTF16?: boolean): void; export declare function hitHighlight(text: string, hits?: number[][], options?: { tag: string }): string; + +export interface ParsedTweet { + weightedLength: number; + permillage: number; + valid: boolean; + displayRangeEnd: number; + displayRangeStart: number; + validRangeEnd: number; + validRangeStart: number; +} + +export declare function parseTweet(text: string): ParsedTweet; From f15552392a347f7b182362e6f4b55cf456df1098 Mon Sep 17 00:00:00 2001 From: Matt Lewis Date: Wed, 27 Dec 2017 21:45:33 +0000 Subject: [PATCH 2/5] Update from review --- types/twitter-text/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/twitter-text/index.d.ts b/types/twitter-text/index.d.ts index df71654bb4..746def795a 100644 --- a/types/twitter-text/index.d.ts +++ b/types/twitter-text/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for twitter-text v2.0.0 // Project: https://github.com/twitter/twitter-text -// Definitions by: rhysd +// Definitions by: rhysd // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped From 4915b607329b17eee7c18153f4da3c8b3370a261 Mon Sep 17 00:00:00 2001 From: Matt Lewis Date: Thu, 28 Dec 2017 10:19:23 +0000 Subject: [PATCH 3/5] Feedback from code review --- types/twitter-text/index.d.ts | 15 ++++++++++++++- types/twitter-text/twitter-text-tests.ts | 3 +++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/types/twitter-text/index.d.ts b/types/twitter-text/index.d.ts index 746def795a..977aa03049 100644 --- a/types/twitter-text/index.d.ts +++ b/types/twitter-text/index.d.ts @@ -113,6 +113,19 @@ export declare function convertUnicodeIndices(text: string, entities: EntityWith export declare function hitHighlight(text: string, hits?: number[][], options?: { tag: string }): string; +export interface ParseTweetOptions { + version?: number; + maxWeightedTweetLength?: number; + scale?: number; + defaultWeight?: number; + transformedURLLength?: number; + ranges?: Array<{ + start: number; + end: number; + weight: number; + }>; +} + export interface ParsedTweet { weightedLength: number; permillage: number; @@ -123,4 +136,4 @@ export interface ParsedTweet { validRangeStart: number; } -export declare function parseTweet(text: string): ParsedTweet; +export declare function parseTweet(text: string, options?: ParseTweetOptions): ParsedTweet; diff --git a/types/twitter-text/twitter-text-tests.ts b/types/twitter-text/twitter-text-tests.ts index a8e198e410..fdf816ec8f 100644 --- a/types/twitter-text/twitter-text-tests.ts +++ b/types/twitter-text/twitter-text-tests.ts @@ -60,3 +60,6 @@ const linked: string = twitter.autoLink("link @user, and expand url... http://t. ]}); const usernames: string[] = twitter.extractMentions("Mentioning @twitter and @jack"); + +const tweet = twitter.parseTweet('foo'); +const tweetWithOptions = twitter.parseTweet('foo', {maxWeightedTweetLength: 140}); From 8c430a8713e4ba395279285596d6e72644d82a13 Mon Sep 17 00:00:00 2001 From: Matt Lewis Date: Thu, 28 Dec 2017 10:21:59 +0000 Subject: [PATCH 4/5] Format code --- types/twitter-text/index.d.ts | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/types/twitter-text/index.d.ts b/types/twitter-text/index.d.ts index 977aa03049..370b46abff 100644 --- a/types/twitter-text/index.d.ts +++ b/types/twitter-text/index.d.ts @@ -115,25 +115,25 @@ export declare function hitHighlight(text: string, hits?: number[][], options?: export interface ParseTweetOptions { version?: number; - maxWeightedTweetLength?: number; - scale?: number; - defaultWeight?: number; - transformedURLLength?: number; - ranges?: Array<{ - start: number; - end: number; - weight: number; - }>; + maxWeightedTweetLength?: number; + scale?: number; + defaultWeight?: number; + transformedURLLength?: number; + ranges?: Array<{ + start: number; + end: number; + weight: number; + }>; } export interface ParsedTweet { - weightedLength: number; - permillage: number; - valid: boolean; - displayRangeEnd: number; - displayRangeStart: number; - validRangeEnd: number; - validRangeStart: number; + weightedLength: number; + permillage: number; + valid: boolean; + displayRangeEnd: number; + displayRangeStart: number; + validRangeEnd: number; + validRangeStart: number; } export declare function parseTweet(text: string, options?: ParseTweetOptions): ParsedTweet; From 627cc0eb929c7bd1f9613029dbb3142a1460cb1b Mon Sep 17 00:00:00 2001 From: Matt Lewis Date: Thu, 28 Dec 2017 10:25:52 +0000 Subject: [PATCH 5/5] Update index.d.ts --- types/twitter-text/index.d.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/types/twitter-text/index.d.ts b/types/twitter-text/index.d.ts index 370b46abff..652f93da51 100644 --- a/types/twitter-text/index.d.ts +++ b/types/twitter-text/index.d.ts @@ -119,11 +119,11 @@ export interface ParseTweetOptions { scale?: number; defaultWeight?: number; transformedURLLength?: number; - ranges?: Array<{ - start: number; - end: number; - weight: number; - }>; + ranges?: Array<{ + start: number; + end: number; + weight: number; + }>; } export interface ParsedTweet {