From bbbc2633179c978b41ab44c6a37a260cf7f4f21b Mon Sep 17 00:00:00 2001 From: Mickael Burguet Date: Tue, 6 Sep 2016 11:12:59 -0400 Subject: [PATCH 1/2] [pino]: Fix constructor argument stream typing --- pino/pino.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pino/pino.d.ts b/pino/pino.d.ts index 1d7049cf05..0a51c49275 100644 --- a/pino/pino.d.ts +++ b/pino/pino.d.ts @@ -41,8 +41,8 @@ declare module 'pino' { } interface Pino { - (optionsOrStream?: LoggerOptions | stream.Writable): Logger - (options: LoggerOptions, stream: stream.Writable): Logger + (optionsOrStream?: LoggerOptions | stream.Writable | stream.Readable): Logger + (options: LoggerOptions, stream: stream.Writable | stream.Readable): Logger levels: { values: LevelLabelsToValues labels: LevelValuesToLabels From 11999b5ef590a1e4101173da776e37f2052705a7 Mon Sep 17 00:00:00 2001 From: Mickael Burguet Date: Wed, 7 Sep 2016 10:06:58 -0400 Subject: [PATCH 2/2] Add testcase --- pino/pino-tests.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pino/pino-tests.ts b/pino/pino-tests.ts index 9a2c423222..4a1470db24 100644 --- a/pino/pino-tests.ts +++ b/pino/pino-tests.ts @@ -26,6 +26,12 @@ var instance = PINO({ } }) +var pretty = PINO.pretty() +var instance2 = PINO({ + name: 'app', + safe: true +}, pretty) + var logger = instance logger.child({ a: 'property' }).info('hello child!')