From 2c5321dfbe880c748067f8a2007185a92f38e851 Mon Sep 17 00:00:00 2001 From: Donald Pipowitch Date: Fri, 5 May 2017 12:56:09 +0200 Subject: [PATCH 1/3] Update index.d.ts --- types/selenium-webdriver/index.d.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/types/selenium-webdriver/index.d.ts b/types/selenium-webdriver/index.d.ts index c8d0c9b2de..f7c92508a8 100644 --- a/types/selenium-webdriver/index.d.ts +++ b/types/selenium-webdriver/index.d.ts @@ -556,6 +556,13 @@ export namespace logging { export namespace promise { // region Functions + + /** + * Set `USE_PROMISE_MANAGER` to `false` to disable the promise manager. + * This is useful, if you use async/await (see https://github.com/SeleniumHQ/selenium/issues/2969 + * and https://github.com/SeleniumHQ/selenium/issues/3037). + */ + let USE_PROMISE_MANAGER: boolean; /** * Given an array of promises, will return a promise that will be fulfilled From f4e3eeec7d16c3bd90725ebc2c89b6b8acadb709 Mon Sep 17 00:00:00 2001 From: Donald Pipowitch Date: Fri, 5 May 2017 13:17:07 +0200 Subject: [PATCH 2/3] remove whitespace --- types/selenium-webdriver/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/types/selenium-webdriver/index.d.ts b/types/selenium-webdriver/index.d.ts index f7c92508a8..2ec8f533ff 100644 --- a/types/selenium-webdriver/index.d.ts +++ b/types/selenium-webdriver/index.d.ts @@ -556,7 +556,7 @@ export namespace logging { export namespace promise { // region Functions - + /** * Set `USE_PROMISE_MANAGER` to `false` to disable the promise manager. * This is useful, if you use async/await (see https://github.com/SeleniumHQ/selenium/issues/2969 From 69f1cbd819a3872005b17108ddb6cda9c41175e5 Mon Sep 17 00:00:00 2001 From: Philipp Zins Date: Mon, 8 May 2017 12:28:59 +0200 Subject: [PATCH 3/3] added test --- types/selenium-webdriver/test/index.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/types/selenium-webdriver/test/index.ts b/types/selenium-webdriver/test/index.ts index f325fe6604..68cdd14fda 100644 --- a/types/selenium-webdriver/test/index.ts +++ b/types/selenium-webdriver/test/index.ts @@ -961,3 +961,7 @@ async function TestAsyncAwaitable() { let thenable: webdriver.promise.Promise = new webdriver.promise.Promise((resolve, reject) => resolve('foo')); let str: string = await thenable; } + +function TestPromiseManagerFlag() { + webdriver.promise.USE_PROMISE_MANAGER = false; +}