Commit Graph

119 Commits

Author SHA1 Message Date
Eugene Y. Q. Shen
f9dcdecd8b [node]: Update assert.fail parameters (#27622)
[assert.fail](https://nodejs.org/api/assert.html#assert_assert_fail_message)
has an optional `message` parameter that can be either a `string` or `Error`.
2018-08-06 09:28:50 -07:00
Louis-Dominique Dubeau
e425a450ce node: add the 3rd parameter to URLSearchParams.forEach (#27732)
The documentation for [URLSearchParams.forEach][1] shows that the
callback function will be called with 3 parameters. This has been true
since Node 6. This commit adds a definition for the 3rd parameter to
the definition files for Node 6, 7, 8, 9 and 10.

[1]: https://nodejs.org/api/url.html#url_urlsearchparams_foreach_fn_thisarg
2018-07-31 15:43:02 -07:00
Akihiko Odaki
8691cd12f7 Add missing maxFreeSockets property of Agent class in node (#27014) 2018-07-05 12:51:29 -07:00
Mine Starks
ee7ef14286
Merge pull request #26407 from r3nya/node-dns-lookup
[node] Add dns.lookupService method
2018-06-13 08:59:26 -07:00
Andrew Makarov
be6409bb59 Update tests 2018-06-10 23:08:28 +03:00
Andrew Makarov
9b615f3a76 Add dns.lookupService method 2018-06-09 23:09:07 +03:00
Sander Koenders
09ff4cfc0a
Fix(node 6): Use ProcessEnv in Process interface 2018-06-08 14:09:33 +02:00
Sander Koenders
8b140f037c
Docs(name): Add my name to contributors list 2018-06-08 13:54:51 +02:00
Sander Koenders
c9bcd193cb
Test(Node 6): Alter test for ProcessEnv 2018-06-08 13:48:10 +02:00
Sander Koenders
bb8dec6a26
Feat(Node 6): Add ProcessEnv interface 2018-06-08 13:00:25 +02:00
Gerhard Stoebich
bd8e2a3d3f [node] add some ReadLineOptions parameters 2018-05-28 21:41:40 +02:00
Ionut Botizan
1b2f3e2ba1 [node] Add debugPort to the Process interface
https://nodejs.org/api/process.html#process_process_debugport
2018-05-17 09:24:41 +03:00
Paul van Brenk
af5dd8fe0f Change node 6 to target es5 (#25719) 2018-05-12 09:49:57 +12:00
Margaret Nolan
c9d2d02185 Add 'external' to node v6, v7, v8, v9, and v10 MemoryUsage interface (#25580) 2018-05-07 12:37:08 -07:00
Andrew Marshall
853ede90a6 node: Add WHATWG URL API types for v6 (#25407)
Added in Node 6.13.0. This copies the respective types from the types
for Node v7.

<https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#6.13.0>
2018-05-07 11:48:04 -07:00
Jérémie Astori
dd0d4ad0c4 Type spawn's args as a ReadonlyArray of string (#25487)
At the moment, this snippet:

```ts
const spawnArgs: ReadonlyArray<string> = ['foo', 'bar'];
spawn('foobar', spawnArgs);
```

fails with:

```
Argument of type 'ReadonlyArray<string>' is not assignable to parameter of type 'string[] | undefined'.
  Type 'ReadonlyArray<string>' is not assignable to type 'string[]'.
```

Looking at https://github.com/nodejs/node/blob/master/lib/child_process.js#L514-L535 and https://github.com/nodejs/node/blob/master/lib/internal/child_process.js#L286, it _looks_ like there is no mutation of the array. I am no expert so I'd be happy to be proven wrong, I just couldn't find sufficient evidence that a `ReadonlyArray` wouldn't be fine.
This is not a breaking change because passing a `string[]` is still valid.
2018-05-03 08:57:27 -07:00
Brian Crowell
edd9c31ed8 [node] Allow object-mode write and writev in WritableOptions (#25263)
Writable's write function accepts chunks of type any to permit object-mode
usage. The implementations you can provide to Writable's constructor should
do the same.
2018-04-30 09:14:16 -07:00
Alexander T
dcf3384ac2 Microsoft/TypeScript#23155 - Type error in Buffer.from() (#24966) 2018-04-13 08:50:15 -07:00
Khải
52670470e3 Change type of path.sep and path.delimiter in @types/node (#24833)
* Update type of path.sep and path.delimiter

* Change `path.sep` to `'\\' | '/'`
* Change `path.delimiter` to  `';' | ':'`

* Update index.d.ts

* Change types of path.sep and path.delimiter in types/node/{v8,v6}

* Change types of path.sep and path.delimiter in types/node/v7
2018-04-09 13:52:55 -07:00
Blair Zajac
4bcf0f6866 node: assert.fail() has never return type. 2018-03-30 23:47:08 -07:00
Frank Schulz
a36a10b2bf Add tests 2018-03-21 12:53:58 +01:00
Frank Schulz
2b5cfcfb05 Fix https type 2018-03-21 12:37:33 +01:00
Steven
1700ece8de Add TlsSocket.getProtocol() to node (#24116) 2018-03-06 14:26:07 -08:00
Andy Hanson
45c9246c09 Remove esModuleInterop from tsconfigs (no longer mandatory) 2018-02-14 14:55:13 -08:00
Daniel Rosenwasser
86e2bc1cf0
Merge pull request #23486 from mentos1386/mentos1386-node-tty-class-fix
[NodeJS] TTY ReadStream Interface to Class fix
2018-02-13 10:31:42 -08:00
Ron Buckton
314132546a
Merge pull request #23374 from johan13/socket-return-types
[node] Fix return type of net.Socket methods
2018-02-08 20:10:45 -08:00
Flarna
97e17866e8 [node] Improve return type of fs.readdir() and fs.readdirsync() (#23440)
* [node] Improve return type of fs.readdir() and fs.readdirsync()

* additionally update v6
2018-02-08 07:33:55 -08:00
Ron Buckton
829640b173
Merge pull request #23427 from Alorel/patch-1
Add encoding option to node.readdir
2018-02-07 15:32:26 -08:00
Tine Jozelj
20f76516d5 Merge branch 'master' into mentos1386-node-tty-class-fix 2018-02-07 17:31:26 +01:00
Denis Malinochkin
a593fd2d60 refactor(node): Remove duplicate line for the «addListener» method (#23449) 2018-02-06 08:47:31 -08:00
Arturas Molcanovas
92e408b5ab Merge branch 'master' into patch-1 2018-02-05 21:18:21 +00:00
Andy
b890bf4556
Fix node tests to be compatible with --esModuleInterop (#23437) 2018-02-05 13:08:34 -08:00
Arturas Molcanovas
760d1d490d Fix path docs 2018-02-05 20:53:26 +00:00
Arturas Molcanovas
d7479d6297 Use readdir types template from v9 2018-02-05 20:50:10 +00:00
Arturas Molcanovas
c1e681c37b merge master 2018-02-05 20:11:57 +00:00
Arturas Molcanovas
16f4c65202 add string buffer 2018-02-05 20:00:26 +00:00
Arturas Molcanovas
bc3f9a7ca7 Merge branch 'patch-1' of https://github.com/Alorel/DefinitelyTyped into patch-1 2018-02-05 19:57:16 +00:00
Arturas Molcanovas
c15ee71643 Add buffer output support 2018-02-05 19:56:40 +00:00
Andy
bef4d2b27d
Enable "esModuleInterop" in all tsconfigs (#23354) 2018-02-05 11:01:56 -08:00
Art
fd35f96ddd
Update index.d.ts
Add definitions author tag
2018-02-05 15:46:48 +00:00
Art
1e48a332ba
Update index.d.ts 2018-02-05 14:31:03 +00:00
Johan Levin
28ac79260d Change return type of net.Socket methods 2018-02-04 21:54:49 +01:00
Andy
37685e11dd Add tslint disables for no-const-enum (#23134) 2018-01-23 18:19:36 +00:00
Evan Shortiss
98f1d85679 Fixed - nodejs core typing for path.resolve args (#22567)
* Fixed - nodejs core typing for path.resolve args

* fix in all versions
2018-01-03 17:03:06 -08:00
Olaf Tomalka
abb6cbad16 Fix Node's path.format() requiring all options (#22525)
* Fix Node's path.format() requiring all options

The bug manifested during use of path.win32 and path.posix submodules.
Both functions required all of the options to exist which is not
the case as some override others.
Further research indicated that previous Node versions were also
susceptible, up to v4.

I've used the Typescript's Partial<> type which makes all properties
optional, allowing for easier maintenance and readabillity at the cost
of now requiring Typescript 2.1, which I believe is a good trade-off.

* Revert the decision to use TS 2.1 in @types/node

Updating Typescript version would require to update
all other types that rely on Node, which may be quite a lot.
Fixing a bug is not a big enough reason to add new version to all
of those packages.
2018-01-03 14:44:18 -08:00
Arthur Ozga
b6b7d5308d
Merge pull request #22077 from Zarel/writable-end
[node] Support passing callback-only in writable.end()
2017-12-19 11:23:30 -08:00
Guangcong Luo
62f093e09c Support passing function only in Node writable.end() 2017-12-14 19:22:16 -06:00
Mine Starks
dc7448628c
Merge pull request #20725 from thewizarodofoz/master
fix Worker.id type
2017-12-13 14:46:37 -08:00
Mine Starks
736ebf768c
Merge pull request #22010 from GrabCAD/master
Add types for Error.prepareStackTrace()
2017-12-11 09:14:14 -08:00
Howard Mak
95b94efe8d Clean up comments for NodeJS.CallSite methods. Make "this" references clearer. 2017-12-07 13:46:40 -05:00