Commit Graph
19 Commits
Author SHA1 Message Date
Po Chen 1fbf734a2c Update index.d.ts 2018-03-29 22:27:54 +11:00
Andy Hanson 45c9246c09 Remove esModuleInterop from tsconfigs (no longer mandatory) 2018-02-14 14:55:13 -08:00
Andy bef4d2b27d Enable "esModuleInterop" in all tsconfigs (#23354) 2018-02-05 11:01:56 -08:00
David Newell 3bb17cd6db Updating the test 2017-11-16 15:43:40 -05:00
David Newell 85375868a1 Typo 2017-11-15 13:22:06 -05:00
David Newell 74f02acb84 Using namespaces 2017-11-15 13:17:56 -05:00
David Newell 21f198290f Lint 2017-11-15 12:59:03 -05:00
David Newell 8d9593b67c Adding sinks function 2017-11-15 12:57:24 -05:00
David Newell 6b38199523 Removing object 2017-11-15 12:56:41 -05:00
David Newell 9f303bef26 Updatinge the Dagre types 2017-11-15 12:12:54 -05:00
David Newell 982861b8ec Updating Dagre types 2017-11-15 11:55:04 -05:00
Andy 947a8fb761 Enable strictFunctionTypes (#20373) 2017-10-06 14:03:03 -07:00
Pete Vilter d2260fff79 Fix dagre types to allow objects to be set as default edge labels (#19945)
The tests call `.setDefaultEdgeLabel(() => {})` which is a translation
to ES6 of something seen in the example in [Dagre's
readme](https://github.com/cpettitt/dagre/wiki#an-example-layout):
`g.setDefaultEdgeLabel(function() { return {}; });`. However, the
translation is botched: `() => {}` doesn't return an empty object, it
returns `undefined`, because `{}` is not an object literal, it's a
block with 0 statements.

I think this is what motivated the current typing to specify that `void`
can be returned by the callback. However, in my experience returning
`undefined` from this callback causes the library to crash. Thus I've
chagned the tests to say `.setDefaultEdgeLabel(() => ({}))` (i.e.
actually return an empty object, which is what the author probably
intended), and updated the types accordingly. This works in my project.
2017-09-26 15:50:00 -07:00
Frankrike f9b25abea0 Add types for missing graph attributes (#19271) 2017-08-25 08:14:17 -07:00
David Newell 0eb19c926a Dagre: Updating Graph, adding GraphOptions (#17657)
* Updating dagre

Cleaning up white space

* Updates based on feedback

* Fixing tests
2017-07-24 12:45:35 -07:00
Andy fa2480ba61 Remove more namespaces from tests (#16029) 2017-04-20 09:06:00 -07:00
Andy e50f8878a5 Use new strict-export-declare-modifiers lint rule (#15844) 2017-04-14 08:20:12 -07:00
Andy bbc61fbf93 Extend "dtslint/dt.json" directly instead of "../tslint.json". (#15822)
* Extend "dtslint/dt.json" directly instead of "../tslint.json".

* Convert more "../tslint.json" to "dtslint/dt.json"

* no-redundant-modifiers -> strict-export-declare-modifiers
2017-04-14 08:04:05 -07:00
Andy Hanson 354cec620d Move all packages to a types directory 2017-03-24 14:27:52 -07:00