vhad/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/gosticks/DefinitelyTyped.git synced 2025-10-16 12:05:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
12,548 Commits 74 Branches 1 Tag 393 MiB
bec5648ef7
Commit Graph

182 Commits

Author SHA1 Message Date
Daniel Rosenwasser
58345fc448 Merge branch 'master' into handleExtraObjectLiteralProperties 
Conflicts:
	angular-ui-bootstrap/angular-ui-bootstrap-tests.ts
 2015-08-17 12:28:46 -07:00
Masahiro Wakame
667ff70834 Merge pull request #5256 from MatthiasHild/patch-1 
Transition.styleTween has incorrect signature
 2015-08-13 23:54:57 +09:00
Daniel Rosenwasser
e9a00d26d8 Add missing 'weight' property to labelAnchorLinks type in 'd3'. 2015-08-11 14:52:35 -07:00
vvakame
eba9f1e2ff remove unrequired .tscparams 2015-08-08 15:41:13 +09:00
Matthias Hild
00c2478e98 Transition.styleTween has incorrect signature 
The signature of Transition.styleTween is currently:

styleTween(name: string, tween: (datum: Datum, index: number, attr: string) => Primitive, priority?: string): Transition<Datum>; (line 833)

Note that the tween is said to return a Primitive. This seems incorrect, both in terms of D3 intent and implementation.

The *correct* version appears to be:

styleTween(name: string, tween: (datum: Datum, index: number, attr: string) => (t: number) => Primitive, priority?: string): Transition<Datum>;

(This is similar to  similar to Transition.attrTween.)

First, the documentation states:

>>> The return value of tween must be an interpolator: a function that maps a parametric value t in the domain [0,1] 
>>>  to a color, number or arbitrary value.

Second, the source code of d3 3.5.5 has:

d3_transitionPrototype.styleTween = function(name, tween, priority) {
    if (arguments.length < 3) priority = "";
    function styleTween(d, i) {
      var f = tween.call(this, d, i, d3_window(this).getComputedStyle(this, null).getPropertyValue(name));
      return f && function(t) {
        this.style.setProperty(name, f(t), priority);
      };
    }
    return this.tween("style." + name, styleTween);
  };

Note the line "this.style.setProperty(name, f(t), priority);" where the result f of applying the tween is passed a parameter t. 

The only point of discussion might be the type of the return value of the tween's interpolator output. Is it Primitive or any? The documentation quoted above (incidentally the same for attrTween and styleTween) explicitly allows for an arbitrary value. I don't have enough D3 experience to know if this is a practically relevant possibility.

Many thanks for your great work on d3.d.ts!!! Especially the use of tweens and interpolators perfectly illustrates the benefits of Typescript.

Best wishes,

Matthias
 2015-08-06 19:02:28 -04:00
Boris Yankov
383a3bc8e6 Merge pull request #5095 from aicioara/master 
[d3] Correct interpolate() signature
 2015-07-31 02:51:34 +03:00
Masahiro Wakame
0c120b7669 Merge pull request #5054 from fmilitao/master 
[d3] added Transition.transition() and optional 'i' on Arc<T>
 2015-07-29 00:10:17 +09:00
Andrei Cioara
f444210ac4 d3: Implemented all forgotten overloadings 2015-07-27 12:43:47 -07:00
Andrei Cioara
c703676114 d3: correct overloading of interpolate() 2015-07-27 12:40:41 -07:00
Filipe
64ccffcc3f fixed type of tween in Transition.attrTween to return interpolator function 2015-07-26 09:23:41 +01:00
Zoe Tsai
507917053c add third arugment to where needed 2015-07-24 16:46:17 -07:00
Filipe
5fef36255d added Transition.transitin() and optional 'i' on Arc<T> 2015-07-24 10:54:44 +01:00
Zoe Tsai
d268fbc77a update d3.d.ts 2015-07-21 15:16:13 -07:00
Zoe Tsai
b27d51b612 update d3.d.ts 2015-07-20 19:36:52 -07:00
mcliment
ba8f92a4f0 d3.js cluster links property should return a collection 2015-07-20 12:17:33 +02:00
Victor Pineda Gonzalez
e95209b243 node() function will return DOM Node 2015-07-15 18:03:01 -05:00
Stefan Steinhart
1e679617ab fixed multi time format 2015-07-10 09:39:20 +02:00
Stefan Steinhart
aaf2dcd5d6 + tickFormat also directly accepts a string parameter 2015-07-02 21:17:45 +02:00
Gildor
1740c40614 fix d3 bisector type signature 2015-06-23 18:03:16 -07:00
Alex Ford
cf09bf76ce Liberalize type of d3.event. Addresses #4590. 2015-06-11 16:09:10 -04:00
Justin Lan
8ab53b38cf Fix some errors in the d3 definitions 
== Interval.offset() ==
Should take a number not a Date as the second parameter
(https://github.com/mbostock/d3/wiki/Time-Intervals#interval_offset)

== svg.line.defined() and svg.area.defined() ==
In two places setter signature for defined() wasn't listed.

== svg.symbol()'s index parameter is optional ==
https://github.com/mbostock/d3/wiki/SVG-Shapes#_symbol
 2015-06-02 21:17:55 -07:00
Alex Ford
808f545d7e Merge branch 'master' of github.com:borisyankov/DefinitelyTyped 
Conflicts:
	d3/d3.d.ts
 2015-05-29 13:27:55 -04:00
Jordi Aranda
c514d8784a Fixes in callback type definition in xhr methods 2015-05-19 18:57:52 +02:00
Jordi Aranda
2dc99a0141 Callback type definition fix in xhr methods 2015-05-19 18:31:48 +02:00
Guillaume Mouron
b0289ac7a3 Insert and append can take functions returning a DOM element 
This is specified in the d3 documentation :
- append : https://github.com/mbostock/d3/wiki/Selections#append
- insert : https://github.com/mbostock/d3/wiki/Selections#insert

Also visible in the code : https://github.com/mbostock/d3/blob/master/d3.js#L802 and https://github.com/mbostock/d3/blob/master/d3.js#L818
 2015-05-18 12:07:28 +02:00
Daniel Beckwith
332ac5b1f4 Adds shiftKey property to D3Event. 2015-05-03 01:10:35 -04:00
hansrwindhoff
08ae0b1793 typing for Arbitrary Delimiters 
https://github.com/mbostock/d3/wiki/CSV#arbitrary-delimiters
 2015-04-20 11:32:59 -06:00
Masahiro Wakame
ebc03ee2d5 Merge pull request #4062 from gildorwang/d3-add-charge-distance 
Add definition for D3 chargeDistance
 2015-04-12 10:19:30 +09:00
Masahiro Wakame
3b78ba4850 Merge pull request #4057 from rcchen/master 
Added interpolate typings for functions in svg.line/area
 2015-04-12 08:38:17 +09:00
Gildor
e52779e5dc Add definition for D3 chargeDistance 2015-04-08 17:44:40 +08:00
Masahiro Wakame
f86c9e1080 Merge pull request #4005 from markwongsk/d3-keyboard-events 
Added more keyboard events to d3.event
 2015-04-07 23:08:14 +09:00
Roger Chen
ddd1b5cbbd Added interpolate typings for functions in svg.line/area 2015-04-06 15:34:20 -07:00
Alex Ford
23515939b9 remove refs to non-existent "D3" 2015-04-03 15:36:58 -04:00
Alex Ford
7be20013e6 Merge branch 'master' of github.com:borisyankov/DefinitelyTyped 
Conflicts:
	d3/d3-tests.ts
	d3/d3.d.ts
 2015-04-03 11:02:57 -04:00
Masahiro Wakame
7cc0989d85 Merge pull request #4017 from bluong/master 
[D3] - Symbol usage optionally takes in datum/index arguments
 2015-04-03 01:18:35 +09:00
Masahiro Wakame
ca93d1daf2 Merge pull request #3894 from abakirov/d3 
Make entire D3.Selection generic
 2015-04-03 01:13:51 +09:00
Brandon Luong
97f2b68e11 making datum/index usage optional 2015-03-31 16:50:21 -07:00
Anatoly Bakirov
0858c16a2c Make entire D3.Selection generic 2015-03-31 15:05:18 -07:00
Alex Ford
663240f969 ordinal scales use any string-coercible type 2015-03-31 11:03:02 -04:00
Alex Ford
b9546998e3 noImplicitAny compliance 2015-03-31 10:51:58 -04:00
Alex Ford
16d084b052 Add more default types for D3 scales 2015-03-31 10:51:43 -04:00
Mark Wong Siang Kai
04a29d46fc Added more keyboard events to d3.event 
-- these events come from https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent
   but I didn't include all of them
 2015-03-30 16:20:23 -07:00
Alex Ford
6f60566a5e add self to contributor header 2015-03-30 15:28:48 -04:00
Alex Ford
39debc285e Fix tests and broken references 2015-03-30 15:26:22 -04:00
Alex Ford
7600257d34 Update d3.d.ts 2015-03-30 14:55:16 -04:00
Audrey
1c05872e78 Include padAngle to PieLayout interface 
Based on line 68 of pie.js https://github.com/mbostock/d3/blob/master/src/layout/pie.js
 2015-03-30 11:53:44 -04:00
Masahiro Wakame
e3d6cc4ba7 Merge pull request #3775 from dani-h/master 
Made all of the GraphNode values optional
 2015-03-25 01:04:29 +09:00
Masahiro Wakame
54ac039b06 Merge pull request #3898 from gcastre/d3 
D3 Add missing optional index parameter
 2015-03-25 00:49:35 +09:00
Grégoire Castre
3fe4c86588 Add missing optional index parameter 2015-03-18 14:23:56 +01:00
Gildor
3890e183a8 Make D3.Selection.datum generic so that return values have type 2015-03-17 14:38:24 +08:00