Commit Graph

24 Commits

Author SHA1 Message Date
Andy Hanson
45c9246c09 Remove esModuleInterop from tsconfigs (no longer mandatory) 2018-02-14 14:55:13 -08:00
Andy
bef4d2b27d
Enable "esModuleInterop" in all tsconfigs (#23354) 2018-02-05 11:01:56 -08:00
Yoyo Zhou
5af4ae7bf0 kafka-node: fix message value to be string or Buffer (#23201) 2018-01-31 12:04:27 -08:00
Yoyo Zhou
f51e60a117 kafka-node: Fix type of Message.key to be optional string (#23041)
key is not a number, it's a string. See KeyedMessage constructor, above.

(However, if `encoding` is specified as "buffer" in ConsumerOptions then `key` and `value` are actually `Buffer` rather than `string`. I'm not sure if it's possible to specify this better than `string|Buffer` since it may not be knowable at compile time.)
2018-01-24 12:02:52 -08:00
Tyson Andre
c219fc824c Add additional events emitted by kafka-node's Client (#22678)
Previously, only KafkaClient (subclass) had signatures for `on()`.
However, Client and KafkaClient emit many of the same events.
- See https://github.com/SOHU-Co/kafka-node/blob/master/lib/client.js
  and https://github.com/SOHU-Co/kafka-node/blob/master/lib/kafkaClient.js
  (Search for the string `emit(`)

zkReconnect is exclusive to Client, and socket_connect is exclusive to
KafkaClient. TypeScript's type checker warns if I put on() declarations
in KafkaClient. (Haven't tried duplicating.)
2018-01-04 12:29:11 -08:00
Andy
097d2acf71 Miscellaneous lint fixes (#20849) 2017-10-22 15:22:50 -07:00
Andy
947a8fb761 Enable strictFunctionTypes (#20373) 2017-10-06 14:03:03 -07:00
Andy
cb2dbfbb50 Add ignores for new lint rules (#19504) 2017-09-01 07:47:52 -07:00
Andy
924fafffc0 Fix remaining lint errors (#19166) 2017-08-20 15:37:53 -07:00
Michael Haan
c9bd9cf538 add on reconnect to KafkaClient (#18614)
Signed-off-by: Michael Haan <haanmd@gmail.com>
2017-08-03 14:38:02 -07:00
Bill Kim
2b0f00ff27 Update kafka node (#18267)
* updating types for kafka-node

* fixed typos

* linter errors

* typo
2017-07-20 15:53:43 -07:00
amiram
59932cbdd6 add test for missing kafkaClient options 2017-07-18 22:21:14 +03:00
amiram
aa245d6c8c add missing kafkaClient options 2017-07-18 22:20:13 +03:00
amiram
34f5e746e2 fix lint 2017-07-18 13:05:42 +03:00
amiram
45cc08937d add tslint 2017-07-18 12:33:54 +03:00
amiram
cc5bb4de93 message properties optional 2017-07-18 12:31:25 +03:00
amiram
063908566c Add new KafkaClient
more fixes to align with version 2
2017-07-18 12:29:18 +03:00
tyler
47379b6753 Update kafka-node tests to add noAckBatchOptions and sslOptions 2017-07-04 12:40:23 +08:00
tyler
d3ceda3ede Add and to for kafka-node 2017-07-04 12:33:14 +08:00
Nathan Shively-Sanders
a949d2289d Merge pull request #17242 from shinhwagk/patch-2
[kafka-node] modify property Client.clientId to Client.clientId?
2017-06-20 09:15:38 -07:00
shinhwagk
3aabbf999d [kafka-node] modify property Client.clientId to Client.clientId?
Client clientId have default value 'kafka-node-client'.
2017-06-16 17:53:57 +08:00
Michael Haan
12741d9392
add sendOffsetCommitV2Request to Client 2017-06-14 13:35:08 -07:00
Michael Haan
8f7d2171e9 kafka-node: add "client: Client" to HighLevelConsumer (#16188)
* added client to ConsumerGroup

* added client to HighLevelConsumer (CG inherits from)
2017-06-01 07:22:23 -07:00
Andy Hanson
354cec620d Move all packages to a types directory 2017-03-24 14:27:52 -07:00